Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: EXC-1652: Future proof canister snapshots #1677

Merged
merged 6 commits into from
Sep 28, 2024

Conversation

berestovskyy
Copy link
Contributor

@berestovskyy berestovskyy commented Sep 25, 2024

Introducing small functions that requires developers to consider the potential impact of adding or removing canister state fields on the canister snapshot logic. This covers changes in CanisterState, SystemState, ExecutionState, WasmBinary and SchedulerState.

@github-actions github-actions bot added the test label Sep 25, 2024
@berestovskyy berestovskyy force-pushed the andriy/exc-1652-future-proof-snapshots branch from 81d3342 to 7c51aaa Compare September 25, 2024 09:14
Copy link
Member

@dsarlis dsarlis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Can you please add a short description of the exact future proofing we're doing?

@berestovskyy berestovskyy added this pull request to the merge queue Sep 28, 2024
Merged via the queue into master with commit 5b4a6e3 Sep 28, 2024
24 checks passed
@berestovskyy berestovskyy deleted the andriy/exc-1652-future-proof-snapshots branch September 28, 2024 09:40
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
Introducing small functions that requires developers to consider the
potential impact of adding or removing canister state fields on the
canister snapshot logic. This covers changes in CanisterState,
SystemState, ExecutionState, WasmBinary and SchedulerState.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants