fix: "Illegal invocation" in service-worker #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
1 similar comment
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
1 similar comment
|
Dear @3cL1p5e7, This repository does not accept external contributions yet. We are therefore closing this Pull Request, thank you for your understanding. — The DFINITY Foundation |
gitlab-dfinity
pushed a commit
that referenced
this pull request
Jan 16, 2024
test(registry): CRP-943: Fix delete subnet test Change the order in which system subnets are deleted in the `test_subnet_is_only_deleted_when_appropriate` test. The test flow is the following: 1. Create three subnets (two system subnets and one application subnet) 2. Verify that deleting a non-existent subnet fails 3. Verify that deleting the (hard-coded) NNS system subnet fails (no subnet with the mainnet NNS subnet ID exists in the test) 4. Verify that deleting the only system subnet fails 5. Verify that deleting the application subnet succeeds 6. Verify that deleting the second system subnet succeeds There are two issues in the test: - At step #4, there are two system subnets, so deleting either one should succeed - Currently, the deletion of the first system subnet fails at step #4 because the `crypto_threshold_signing_public_key` and `catch_up_package_contents` of that subnet is missing: `2024-01-09 16:31:05.727480874 UTC: [Canister rwlgt-iiaaa-aaaaa-aaaaa-cai] Panicked at '[Registry] Verification of the mutation type failed with the following errors: [Registry Canister Error. Msg: Key not present: catch_up_package_contents_ya35z-hhham-aaaaa-aaaap-yai, Registry Canister Error. Msg: Key not present: crypto_threshold_signing_public_key_ya35z-hhham-aaaaa-aaaap-yai].', rs/registry/canister/src/registry.rs:293:13` The reason why the system subnet deletion currently fails in step #4, but succeeds for the other system subnet in step #6, is because the first subnet is created in `invariant_compliant_mutation_as_atomic_req` which does not set the `crypto_threshold_signing_public_key` or `catch_up_package_contents` for the subnet, but the subsequently created second system subnet does have the `crypto_threshold_signing_public_key` and `catch_up_package_contents` set. The (temporary) fix in this MR does the following: - At step #4, verify that deleting the second system subnet succeeds - At step #6, verify that deleting the first (and now only) system subnet fails A more comprehensive fix that also sets `crypto_threshold_signing_public_key` and `catch_up_package_contents` for the first system subnet will follow in [a subsequent MR](https://gitlab.com/dfinity-lab/public/ic/-/merge_requests/17063). See merge request dfinity-lab/public/ic!17062
gitlab-dfinity
pushed a commit
that referenced
this pull request
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix of error message
Failed to fetch response: TypeError: Failed to execute ‘fetch’ on ‘WorkerGlobalScope’: Illegal invocationwhile using service-worker in browser.Found, solved and tested in this forum topic
To solve the problem you can accept current PR or accept another PR for agent-js and update dependencies here