feat(nns): Implement proposal execution for updating settings for root #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonz-dfinity
changed the title
jasonz-dfinity
commented
Aug 9, 2024
|
Another thing you (can|should) mention in the "Why" section:
IOW, it should explain why root is special (the short answer is that its set of controllers is different compared to other NNS canisters). |
daniel-wong-dfinity-org
approved these changes
Aug 12, 2024
jasonz-dfinity
force-pushed
the
jason/NNS1-3216
branch
from
877724d
to
870aa72
Compare
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
dfinity#866) # Why The `update_canister_settings` proposal type should work on cansiters controlled by root (already implemented) as well as root itself (this PR) Only a controller of a canister can change its settings. lifeline is the controller of root. Therefore, execution of update settings proposals that target root are implemented by calling a (new) method of lifeline. Whereas, for all other NNS canisters, update settings proposals are implemented via a call to root. # What * Add an endpoint on the lifeline (update_root_settings) * Call `Lifeline::update_root_settings` from Governance for proposal execution * Minor changes * Fix the error messages for some times * Fix the lifeline.did which was out-dated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
update_canister_settingsproposal type should work on cansiters controlled by root (already implemented) as well as root itself (this PR)Only a controller of a canister can change its settings. lifeline is the controller of root. Therefore, execution of update settings proposals that target root are implemented by calling a (new) method of lifeline. Whereas, for all other NNS canisters, update settings proposals are implemented via a call to root.
What
Lifeline::update_root_settingsfrom Governance for proposal execution