refactor(nns): Cleanup NNS Governance API type definitions #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
5db8bb1
to
65cf8e8
Compare
max-dfinity
reviewed
Aug 15, 2024
max-dfinity
approved these changes
Aug 16, 2024
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
65cf8e8
to
aad512b
Compare
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
aad512b
to
71cd5f9
Compare
anchpop
force-pushed
the
@anchpop/clean-up-api
branch
from
71cd5f9
to
4e75858
Compare
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
We previously auto-generated these, but the auto-generated added a lot of cruft because the files were not meant to be hand-edited. Now that we're hand-editing them, we can simplify some of that. This PR does **not** actually change any of the types in a practical sense, it just reorganizes how they refer to the types of their fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously auto-generated these, but the auto-generated added a lot of cruft because the files were not meant to be hand-edited. Now that we're hand-editing them, we can simplify some of that.
This PR does not actually change any of the types in a practical sense, it just reorganizes how they refer to the types of their fields