-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(drun): Enable Wasm64 with 16GB main memory capacity #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luc-blaeser
changed the title
drun: Enable Wasm64 with 16GB main memory capacity
chore(drun): Enable Wasm64 with 16GB main memory capacity
Aug 19, 2024
Not sure whether we should stick to the IC's default main memory size and only enable Wasm Memory64? |
mergify bot
pushed a commit
to dfinity/motoko
that referenced
this pull request
Sep 9, 2024
Using IC 2024-08-16 with some adjustments: * `drun` adjustments for better testing - dfinity/ic#662 (Lift 8GB memory boundary from drun) - dfinity/ic#988 (Enable Wasm64 with 16GB main memory capacity) - dfinity/ic#991 (Disable DTS for deterministic debug outputs) - dfinity/ic#992 (Increase batch limit for longer running tests) - dfinity/ic#1240 (Enable canister snapshots) * IC build fixes for `nix`: - Remove duplicate entries of same crate with same versions in `Cargo.toml`. - dfinity/ic#993 (Fix MacOS `rocksdb` dependency). * Other IC fixes: - dfinity/ic#1250 (Fix canister snapshots)
crusso
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er/ic into luc/drun-enable-wasm64
levifeldman
pushed a commit
to levifeldman/ic
that referenced
this pull request
Oct 1, 2024
For testing IC's prepared extension of Wasm Memory64 in `drun` (while still being disabled in the IC): * Enable Wasm Memory64 in `drun`. * Allow 16 GB of Wasm main memory in `drun`. This is used for CI of Motoko's enhanced orthogonal persistence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing IC's prepared extension of Wasm Memory64 in
drun
(while still being disabled in the IC):drun
.drun
.This is used for CI of Motoko's enhanced orthogonal persistence.