Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(drun): Enable Wasm64 with 16GB main memory capacity #988

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

luc-blaeser
Copy link
Contributor

For testing IC's prepared extension of Wasm Memory64 in drun (while still being disabled in the IC):

  • Enable Wasm Memory64 in drun.
  • Allow 16 GB of Wasm main memory in drun.

This is used for CI of Motoko's enhanced orthogonal persistence.

@luc-blaeser luc-blaeser requested a review from a team as a code owner August 19, 2024 11:48
@luc-blaeser luc-blaeser self-assigned this Aug 19, 2024
@luc-blaeser luc-blaeser changed the title drun: Enable Wasm64 with 16GB main memory capacity chore(drun): Enable Wasm64 with 16GB main memory capacity Aug 19, 2024
@github-actions github-actions bot added the chore label Aug 19, 2024
@luc-blaeser
Copy link
Contributor Author

Not sure whether we should stick to the IC's default main memory size and only enable Wasm Memory64?

mergify bot pushed a commit to dfinity/motoko that referenced this pull request Sep 9, 2024
Using IC 2024-08-16 with some adjustments:
* `drun` adjustments for better testing
   - dfinity/ic#662 (Lift 8GB memory boundary from drun)
   - dfinity/ic#988 (Enable Wasm64 with 16GB main memory capacity)
   - dfinity/ic#991 (Disable DTS for deterministic debug outputs)
   - dfinity/ic#992 (Increase batch limit for longer running tests)
   - dfinity/ic#1240 (Enable canister snapshots)
* IC build fixes for `nix`:
   - Remove duplicate entries of same crate with same versions in `Cargo.toml`.
   - dfinity/ic#993 (Fix MacOS `rocksdb` dependency).
* Other IC fixes:
   - dfinity/ic#1250 (Fix canister snapshots)
Copy link

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luc-blaeser luc-blaeser added this pull request to the merge queue Sep 11, 2024
Merged via the queue into master with commit 1a14c58 Sep 11, 2024
24 checks passed
@luc-blaeser luc-blaeser deleted the luc/drun-enable-wasm64 branch September 11, 2024 09:13
levifeldman pushed a commit to levifeldman/ic that referenced this pull request Oct 1, 2024
For testing IC's prepared extension of Wasm Memory64 in `drun` (while
still being disabled in the IC):
* Enable Wasm Memory64 in `drun`.
* Allow 16 GB of Wasm main memory in `drun`.

This is used for CI of Motoko's enhanced orthogonal persistence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants