Show custom landing page for known dapps #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a few variations to the landing page, esp. to show some prettier information (logo, actual name instead of just URL) for known dapps (i.e. dapps we use for the explorer). This also adds a new screenshot for every page that contains a chasm, that shows the chasm open. This includes a workaround where the frontend uses the `II_DUMMY_CAPTCHA` value to assume the dapp is in a "test" environment, in which case it includes an extra "known dapp" for testing purposes.
nmattia
commented
May 12, 2023
|
|
||
| // There are a few variations of this screen that share some common elements | ||
|
|
||
| // Variation: the dapp is known and user is using II for the first time |
There was a problem hiding this comment.
It would be nice for these helpers to live outside the function. Unfortunately there is a lot of state to thread through (knownDapp, action, copy) which makes everything more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few variations to the landing page, esp. to show some prettier information (logo, actual name instead of just URL) for known dapps (i.e. dapps we use for the explorer).
This also adds a new screenshot for every page that contains a chasm, that shows the chasm open.
This includes a workaround where the frontend uses the
II_DUMMY_CAPTCHAvalue to assume the dapp is in a "test" environment, in which case it includes an extra "known dapp" for testing purposes.This is unfortunate but I didn't think it was worth adding a build flag just for this. I'll try to come up with a better solution soon, maybe using vite conf files as @peterpeterparker suggested.