Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toaster position #1612

Merged
merged 6 commits into from
May 22, 2023
Merged

Fix toaster position #1612

merged 6 commits into from
May 22, 2023

Conversation

meodai
Copy link
Collaborator

@meodai meodai commented May 16, 2023

Makes sure the error messages are always above the footer.

@meodai meodai marked this pull request as ready for review May 16, 2023 13:34
@nmattia nmattia changed the title Toaster position fix Fix toaster position May 22, 2023
nmattia
nmattia reviewed May 22, 2023
View reviewed changes
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meodai didn't we decide on making the toasts appear at the bottom of the screen, but on top of the footer? otherwise when there's no footer they look like they're floating

nmattia
nmattia approved these changes May 22, 2023
View reviewed changes
Copy link
Collaborator

@nmattia nmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline

@meodai meodai enabled auto-merge May 22, 2023 13:16
@meodai meodai added this pull request to the merge queue May 22, 2023
Merged via the queue into main with commit 50a090a May 22, 2023
@meodai meodai deleted the da-error-positioning branch May 22, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmattia nmattia nmattia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meodai @nmattia