Add HTTP response certification v2 #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds certification v2 support for assets served by II. See specification here: https://github.com/dfinity/interface-spec/blob/master/spec/http-gateway-protocol-spec.md#the-http-gateway-protocol-specification This PR contains only contains the minimal required features of v2 certification. In particular, we do not yet take advantage of: * fast redirects * wildcard certification for certified 404 pages * certification opt-out for dynamic data (i.e. /metrics) The certification v1 support is maintained.
przydatek
reviewed
May 31, 2023
added 2 commits
May 31, 2023 16:53
For some reason, this fixes the reproducibility issue.
added 2 commits
May 31, 2023 17:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds certification v2 support for assets served by II.
See specification here: https://github.com/dfinity/interface-spec/blob/master/spec/http-gateway-protocol-spec.md#the-http-gateway-protocol-specification
This PR contains only contains the minimal required features of v2
certification.
In particular, we do not yet take advantage of:
The certification v1 support is maintained.