Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async lowering failures #71

Closed
nomeata opened this issue Nov 13, 2018 · 3 comments
Closed

async lowering failures #71

nomeata opened this issue Nov 13, 2018 · 3 comments
Assignees

Comments

@nomeata
Copy link
Collaborator

nomeata commented Nov 13, 2018

This program typechecks:

let a = actor {
  hello () : async Text {
    "Hello ";
  };
  world () : async Text {
    "World!\n"
  };
  go () : async () {
    print((await hello()) # (await world()));
  };
};

let _ = a.go()

Yet the lowering seems to do the wrong thing, as shown by compiling this with -dl:

(BlockE
  (LetD
    (VarP a)
    (ObjE
      Actor
      anon-actor-1.9
…
      (go
        go
        (DecE
          (FuncD
            Local
            go
            (TupP (TupP) (VarP $13))
            (TupT
              (FuncT Call Local (FuncT Call Local (TupT) (TupT)) (TupT))
              (FuncT
                Call Sharable
                (FuncT Call Local (FuncT Call Local (TupT) (TupT)) (TupT))
                (TupT)
              )
            )
            (CallE
…
          )
        )
        Const
        Public
      )
    )
  )
  (LetD WildP (CallE (DotE (VarE a) go) (TupE)))
)

Note that the type of a.go changes: It gains an extra parameter taking the continuation, but the call to a.go is not affected.

@crusso
Copy link
Contributor

crusso commented Nov 13, 2018

Yeah, I'm looking a the code again and finding lots of issue. Hold off
for now...

@nomeata
Copy link
Collaborator Author

nomeata commented Nov 13, 2018

Ok ok :-)

@crusso
Copy link
Contributor

crusso commented Nov 13, 2018

Buggy as promised ;->

nomeata added a commit that referenced this issue Nov 13, 2018
where we can actually observe the `print` command.
@crusso crusso closed this as completed Nov 14, 2018
dfinity-bot added a commit that referenced this issue Feb 17, 2022
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@4abda083...358326f4](dfinity/ic-hs@4abda08...358326f)

* [`ab8e3f5a`](dfinity/ic-hs@ab8e3f5) EXC-783: Remove limit on Cycles in a canister ([dfinity/ic-hs⁠#70](https://togithub.com/dfinity/ic-hs/issues/70))
* [`2e8bb23d`](dfinity/ic-hs@2e8bb23) Fix mergify configuration ([dfinity/ic-hs⁠#72](https://togithub.com/dfinity/ic-hs/issues/72))
* [`358326f4`](dfinity/ic-hs@358326f) Enable canisters to send HTTP requests ([dfinity/ic-hs⁠#71](https://togithub.com/dfinity/ic-hs/issues/71))
dfinity-bot added a commit that referenced this issue Feb 19, 2022
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@4abda083...f771c6b3](dfinity/ic-hs@4abda08...f771c6b)

* [`ab8e3f5a`](dfinity/ic-hs@ab8e3f5) EXC-783: Remove limit on Cycles in a canister ([dfinity/ic-hs⁠#70](https://togithub.com/dfinity/ic-hs/issues/70))
* [`2e8bb23d`](dfinity/ic-hs@2e8bb23) Fix mergify configuration ([dfinity/ic-hs⁠#72](https://togithub.com/dfinity/ic-hs/issues/72))
* [`358326f4`](dfinity/ic-hs@358326f) Enable canisters to send HTTP requests ([dfinity/ic-hs⁠#71](https://togithub.com/dfinity/ic-hs/issues/71))
* [`f771c6b3`](dfinity/ic-hs@f771c6b) Bump http-client ([dfinity/ic-hs⁠#73](https://togithub.com/dfinity/ic-hs/issues/73))
dfinity-bot added a commit that referenced this issue Feb 23, 2022
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@4abda083...f771c6b3](dfinity/ic-hs@4abda08...f771c6b)

* [`ab8e3f5a`](dfinity/ic-hs@ab8e3f5) EXC-783: Remove limit on Cycles in a canister ([dfinity/ic-hs⁠#70](https://togithub.com/dfinity/ic-hs/issues/70))
* [`2e8bb23d`](dfinity/ic-hs@2e8bb23) Fix mergify configuration ([dfinity/ic-hs⁠#72](https://togithub.com/dfinity/ic-hs/issues/72))
* [`358326f4`](dfinity/ic-hs@358326f) Enable canisters to send HTTP requests ([dfinity/ic-hs⁠#71](https://togithub.com/dfinity/ic-hs/issues/71))
* [`f771c6b3`](dfinity/ic-hs@f771c6b) Bump http-client ([dfinity/ic-hs⁠#73](https://togithub.com/dfinity/ic-hs/issues/73))
mergify bot pushed a commit that referenced this issue Mar 6, 2022
## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@4abda083...f771c6b3](dfinity/ic-hs@4abda08...f771c6b)

* [`ab8e3f5a`](dfinity/ic-hs@ab8e3f5) EXC-783: Remove limit on Cycles in a canister ([dfinity/ic-hs⁠#70](https://togithub.com/dfinity/ic-hs/issues/70))
* [`2e8bb23d`](dfinity/ic-hs@2e8bb23) Fix mergify configuration ([dfinity/ic-hs⁠#72](https://togithub.com/dfinity/ic-hs/issues/72))
* [`358326f4`](dfinity/ic-hs@358326f) Enable canisters to send HTTP requests ([dfinity/ic-hs⁠#71](https://togithub.com/dfinity/ic-hs/issues/71))
* [`f771c6b3`](dfinity/ic-hs@f771c6b) Bump http-client ([dfinity/ic-hs⁠#73](https://togithub.com/dfinity/ic-hs/issues/73))
dfinity-bot added a commit that referenced this issue Sep 6, 2024
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@61692f44...9f3c746e](dfinity/ic-wasm@61692f4...9f3c746)

* [`b1c63d57`](dfinity/ic-wasm@b1c63d5) Support gzipped WASM inputs in `utils::parse_wasm` and `utils::parse_wasm_file` ([dfinity/ic-wasm⁠#55](https://togithub.com/dfinity/ic-wasm/issues/55))
* [`b79469e0`](dfinity/ic-wasm@b79469e) release ([dfinity/ic-wasm⁠#56](https://togithub.com/dfinity/ic-wasm/issues/56))
* [`2eb0900b`](dfinity/ic-wasm@2eb0900) Bump dependencies ([dfinity/ic-wasm⁠#57](https://togithub.com/dfinity/ic-wasm/issues/57))
* [`2d0707f0`](dfinity/ic-wasm@2d0707f) fix: RUN-1002: Enable WebAssembly SIMD in optimization pass ([dfinity/ic-wasm⁠#58](https://togithub.com/dfinity/ic-wasm/issues/58))
* [`d45e0b9d`](dfinity/ic-wasm@d45e0b9) release ([dfinity/ic-wasm⁠#59](https://togithub.com/dfinity/ic-wasm/issues/59))
* [`535a3b51`](dfinity/ic-wasm@535a3b5) chore!: upgrade walrus to support memory64 and release 0.8.0 ([dfinity/ic-wasm⁠#61](https://togithub.com/dfinity/ic-wasm/issues/61))
* [`61b6f12f`](dfinity/ic-wasm@61b6f12) remove arm32 build ([dfinity/ic-wasm⁠#60](https://togithub.com/dfinity/ic-wasm/issues/60))
* [`84eb4483`](dfinity/ic-wasm@84eb448) Correct the value of `GZIPPED_WASM_MAGIC_BYTES` ([dfinity/ic-wasm⁠#64](https://togithub.com/dfinity/ic-wasm/issues/64))
* [`1d48658d`](dfinity/ic-wasm@1d48658) redirect canister snapshot calls ([dfinity/ic-wasm⁠#63](https://togithub.com/dfinity/ic-wasm/issues/63))
* [`18809368`](dfinity/ic-wasm@1880936) feat: add support for limiting Wasm heap memory ([dfinity/ic-wasm⁠#65](https://togithub.com/dfinity/ic-wasm/issues/65))
* [`c5217c76`](dfinity/ic-wasm@c5217c7) bump version ([dfinity/ic-wasm⁠#66](https://togithub.com/dfinity/ic-wasm/issues/66))
* [`c9439739`](dfinity/ic-wasm@c943973) fix memory id in limit_resource ([dfinity/ic-wasm⁠#67](https://togithub.com/dfinity/ic-wasm/issues/67))
* [`9293dfcc`](dfinity/ic-wasm@9293dfc) Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows ([dfinity/ic-wasm⁠#68](https://togithub.com/dfinity/ic-wasm/issues/68))
* [`085bbbff`](dfinity/ic-wasm@085bbbf) feat(EXC): Name Section for Metadata Command ([dfinity/ic-wasm⁠#69](https://togithub.com/dfinity/ic-wasm/issues/69))
* [`5fe03958`](dfinity/ic-wasm@5fe0395) chore: release v0.8.4 ([dfinity/ic-wasm⁠#70](https://togithub.com/dfinity/ic-wasm/issues/70))
* [`9f3c746e`](dfinity/ic-wasm@9f3c746) Fix http_request redirect ([dfinity/ic-wasm⁠#71](https://togithub.com/dfinity/ic-wasm/issues/71))
dfinity-bot added a commit that referenced this issue Sep 10, 2024
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@61692f44...9f3c746e](dfinity/ic-wasm@61692f4...9f3c746)

* [`b1c63d57`](dfinity/ic-wasm@b1c63d5) Support gzipped WASM inputs in `utils::parse_wasm` and `utils::parse_wasm_file` ([dfinity/ic-wasm⁠#55](https://togithub.com/dfinity/ic-wasm/issues/55))
* [`b79469e0`](dfinity/ic-wasm@b79469e) release ([dfinity/ic-wasm⁠#56](https://togithub.com/dfinity/ic-wasm/issues/56))
* [`2eb0900b`](dfinity/ic-wasm@2eb0900) Bump dependencies ([dfinity/ic-wasm⁠#57](https://togithub.com/dfinity/ic-wasm/issues/57))
* [`2d0707f0`](dfinity/ic-wasm@2d0707f) fix: RUN-1002: Enable WebAssembly SIMD in optimization pass ([dfinity/ic-wasm⁠#58](https://togithub.com/dfinity/ic-wasm/issues/58))
* [`d45e0b9d`](dfinity/ic-wasm@d45e0b9) release ([dfinity/ic-wasm⁠#59](https://togithub.com/dfinity/ic-wasm/issues/59))
* [`535a3b51`](dfinity/ic-wasm@535a3b5) chore!: upgrade walrus to support memory64 and release 0.8.0 ([dfinity/ic-wasm⁠#61](https://togithub.com/dfinity/ic-wasm/issues/61))
* [`61b6f12f`](dfinity/ic-wasm@61b6f12) remove arm32 build ([dfinity/ic-wasm⁠#60](https://togithub.com/dfinity/ic-wasm/issues/60))
* [`84eb4483`](dfinity/ic-wasm@84eb448) Correct the value of `GZIPPED_WASM_MAGIC_BYTES` ([dfinity/ic-wasm⁠#64](https://togithub.com/dfinity/ic-wasm/issues/64))
* [`1d48658d`](dfinity/ic-wasm@1d48658) redirect canister snapshot calls ([dfinity/ic-wasm⁠#63](https://togithub.com/dfinity/ic-wasm/issues/63))
* [`18809368`](dfinity/ic-wasm@1880936) feat: add support for limiting Wasm heap memory ([dfinity/ic-wasm⁠#65](https://togithub.com/dfinity/ic-wasm/issues/65))
* [`c5217c76`](dfinity/ic-wasm@c5217c7) bump version ([dfinity/ic-wasm⁠#66](https://togithub.com/dfinity/ic-wasm/issues/66))
* [`c9439739`](dfinity/ic-wasm@c943973) fix memory id in limit_resource ([dfinity/ic-wasm⁠#67](https://togithub.com/dfinity/ic-wasm/issues/67))
* [`9293dfcc`](dfinity/ic-wasm@9293dfc) Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows ([dfinity/ic-wasm⁠#68](https://togithub.com/dfinity/ic-wasm/issues/68))
* [`085bbbff`](dfinity/ic-wasm@085bbbf) feat(EXC): Name Section for Metadata Command ([dfinity/ic-wasm⁠#69](https://togithub.com/dfinity/ic-wasm/issues/69))
* [`5fe03958`](dfinity/ic-wasm@5fe0395) chore: release v0.8.4 ([dfinity/ic-wasm⁠#70](https://togithub.com/dfinity/ic-wasm/issues/70))
* [`9f3c746e`](dfinity/ic-wasm@9f3c746) Fix http_request redirect ([dfinity/ic-wasm⁠#71](https://togithub.com/dfinity/ic-wasm/issues/71))
dfinity-bot added a commit that referenced this issue Sep 11, 2024
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@61692f44...9f3c746e](dfinity/ic-wasm@61692f4...9f3c746)

* [`b1c63d57`](dfinity/ic-wasm@b1c63d5) Support gzipped WASM inputs in `utils::parse_wasm` and `utils::parse_wasm_file` ([dfinity/ic-wasm⁠#55](https://togithub.com/dfinity/ic-wasm/issues/55))
* [`b79469e0`](dfinity/ic-wasm@b79469e) release ([dfinity/ic-wasm⁠#56](https://togithub.com/dfinity/ic-wasm/issues/56))
* [`2eb0900b`](dfinity/ic-wasm@2eb0900) Bump dependencies ([dfinity/ic-wasm⁠#57](https://togithub.com/dfinity/ic-wasm/issues/57))
* [`2d0707f0`](dfinity/ic-wasm@2d0707f) fix: RUN-1002: Enable WebAssembly SIMD in optimization pass ([dfinity/ic-wasm⁠#58](https://togithub.com/dfinity/ic-wasm/issues/58))
* [`d45e0b9d`](dfinity/ic-wasm@d45e0b9) release ([dfinity/ic-wasm⁠#59](https://togithub.com/dfinity/ic-wasm/issues/59))
* [`535a3b51`](dfinity/ic-wasm@535a3b5) chore!: upgrade walrus to support memory64 and release 0.8.0 ([dfinity/ic-wasm⁠#61](https://togithub.com/dfinity/ic-wasm/issues/61))
* [`61b6f12f`](dfinity/ic-wasm@61b6f12) remove arm32 build ([dfinity/ic-wasm⁠#60](https://togithub.com/dfinity/ic-wasm/issues/60))
* [`84eb4483`](dfinity/ic-wasm@84eb448) Correct the value of `GZIPPED_WASM_MAGIC_BYTES` ([dfinity/ic-wasm⁠#64](https://togithub.com/dfinity/ic-wasm/issues/64))
* [`1d48658d`](dfinity/ic-wasm@1d48658) redirect canister snapshot calls ([dfinity/ic-wasm⁠#63](https://togithub.com/dfinity/ic-wasm/issues/63))
* [`18809368`](dfinity/ic-wasm@1880936) feat: add support for limiting Wasm heap memory ([dfinity/ic-wasm⁠#65](https://togithub.com/dfinity/ic-wasm/issues/65))
* [`c5217c76`](dfinity/ic-wasm@c5217c7) bump version ([dfinity/ic-wasm⁠#66](https://togithub.com/dfinity/ic-wasm/issues/66))
* [`c9439739`](dfinity/ic-wasm@c943973) fix memory id in limit_resource ([dfinity/ic-wasm⁠#67](https://togithub.com/dfinity/ic-wasm/issues/67))
* [`9293dfcc`](dfinity/ic-wasm@9293dfc) Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows ([dfinity/ic-wasm⁠#68](https://togithub.com/dfinity/ic-wasm/issues/68))
* [`085bbbff`](dfinity/ic-wasm@085bbbf) feat(EXC): Name Section for Metadata Command ([dfinity/ic-wasm⁠#69](https://togithub.com/dfinity/ic-wasm/issues/69))
* [`5fe03958`](dfinity/ic-wasm@5fe0395) chore: release v0.8.4 ([dfinity/ic-wasm⁠#70](https://togithub.com/dfinity/ic-wasm/issues/70))
* [`9f3c746e`](dfinity/ic-wasm@9f3c746) Fix http_request redirect ([dfinity/ic-wasm⁠#71](https://togithub.com/dfinity/ic-wasm/issues/71))
dfinity-bot added a commit that referenced this issue Sep 18, 2024
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@61692f44...9f3c746e](dfinity/ic-wasm@61692f4...9f3c746)

* [`b1c63d57`](dfinity/ic-wasm@b1c63d5) Support gzipped WASM inputs in `utils::parse_wasm` and `utils::parse_wasm_file` ([dfinity/ic-wasm⁠#55](https://togithub.com/dfinity/ic-wasm/issues/55))
* [`b79469e0`](dfinity/ic-wasm@b79469e) release ([dfinity/ic-wasm⁠#56](https://togithub.com/dfinity/ic-wasm/issues/56))
* [`2eb0900b`](dfinity/ic-wasm@2eb0900) Bump dependencies ([dfinity/ic-wasm⁠#57](https://togithub.com/dfinity/ic-wasm/issues/57))
* [`2d0707f0`](dfinity/ic-wasm@2d0707f) fix: RUN-1002: Enable WebAssembly SIMD in optimization pass ([dfinity/ic-wasm⁠#58](https://togithub.com/dfinity/ic-wasm/issues/58))
* [`d45e0b9d`](dfinity/ic-wasm@d45e0b9) release ([dfinity/ic-wasm⁠#59](https://togithub.com/dfinity/ic-wasm/issues/59))
* [`535a3b51`](dfinity/ic-wasm@535a3b5) chore!: upgrade walrus to support memory64 and release 0.8.0 ([dfinity/ic-wasm⁠#61](https://togithub.com/dfinity/ic-wasm/issues/61))
* [`61b6f12f`](dfinity/ic-wasm@61b6f12) remove arm32 build ([dfinity/ic-wasm⁠#60](https://togithub.com/dfinity/ic-wasm/issues/60))
* [`84eb4483`](dfinity/ic-wasm@84eb448) Correct the value of `GZIPPED_WASM_MAGIC_BYTES` ([dfinity/ic-wasm⁠#64](https://togithub.com/dfinity/ic-wasm/issues/64))
* [`1d48658d`](dfinity/ic-wasm@1d48658) redirect canister snapshot calls ([dfinity/ic-wasm⁠#63](https://togithub.com/dfinity/ic-wasm/issues/63))
* [`18809368`](dfinity/ic-wasm@1880936) feat: add support for limiting Wasm heap memory ([dfinity/ic-wasm⁠#65](https://togithub.com/dfinity/ic-wasm/issues/65))
* [`c5217c76`](dfinity/ic-wasm@c5217c7) bump version ([dfinity/ic-wasm⁠#66](https://togithub.com/dfinity/ic-wasm/issues/66))
* [`c9439739`](dfinity/ic-wasm@c943973) fix memory id in limit_resource ([dfinity/ic-wasm⁠#67](https://togithub.com/dfinity/ic-wasm/issues/67))
* [`9293dfcc`](dfinity/ic-wasm@9293dfc) Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows ([dfinity/ic-wasm⁠#68](https://togithub.com/dfinity/ic-wasm/issues/68))
* [`085bbbff`](dfinity/ic-wasm@085bbbf) feat(EXC): Name Section for Metadata Command ([dfinity/ic-wasm⁠#69](https://togithub.com/dfinity/ic-wasm/issues/69))
* [`5fe03958`](dfinity/ic-wasm@5fe0395) chore: release v0.8.4 ([dfinity/ic-wasm⁠#70](https://togithub.com/dfinity/ic-wasm/issues/70))
* [`9f3c746e`](dfinity/ic-wasm@9f3c746) Fix http_request redirect ([dfinity/ic-wasm⁠#71](https://togithub.com/dfinity/ic-wasm/issues/71))
mergify bot pushed a commit that referenced this issue Sep 18, 2024
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@61692f44...9f3c746e](dfinity/ic-wasm@61692f4...9f3c746)

* [`b1c63d57`](dfinity/ic-wasm@b1c63d5) Support gzipped WASM inputs in `utils::parse_wasm` and `utils::parse_wasm_file` ([dfinity/ic-wasm⁠#55](https://togithub.com/dfinity/ic-wasm/issues/55))
* [`b79469e0`](dfinity/ic-wasm@b79469e) release ([dfinity/ic-wasm⁠#56](https://togithub.com/dfinity/ic-wasm/issues/56))
* [`2eb0900b`](dfinity/ic-wasm@2eb0900) Bump dependencies ([dfinity/ic-wasm⁠#57](https://togithub.com/dfinity/ic-wasm/issues/57))
* [`2d0707f0`](dfinity/ic-wasm@2d0707f) fix: RUN-1002: Enable WebAssembly SIMD in optimization pass ([dfinity/ic-wasm⁠#58](https://togithub.com/dfinity/ic-wasm/issues/58))
* [`d45e0b9d`](dfinity/ic-wasm@d45e0b9) release ([dfinity/ic-wasm⁠#59](https://togithub.com/dfinity/ic-wasm/issues/59))
* [`535a3b51`](dfinity/ic-wasm@535a3b5) chore!: upgrade walrus to support memory64 and release 0.8.0 ([dfinity/ic-wasm⁠#61](https://togithub.com/dfinity/ic-wasm/issues/61))
* [`61b6f12f`](dfinity/ic-wasm@61b6f12) remove arm32 build ([dfinity/ic-wasm⁠#60](https://togithub.com/dfinity/ic-wasm/issues/60))
* [`84eb4483`](dfinity/ic-wasm@84eb448) Correct the value of `GZIPPED_WASM_MAGIC_BYTES` ([dfinity/ic-wasm⁠#64](https://togithub.com/dfinity/ic-wasm/issues/64))
* [`1d48658d`](dfinity/ic-wasm@1d48658) redirect canister snapshot calls ([dfinity/ic-wasm⁠#63](https://togithub.com/dfinity/ic-wasm/issues/63))
* [`18809368`](dfinity/ic-wasm@1880936) feat: add support for limiting Wasm heap memory ([dfinity/ic-wasm⁠#65](https://togithub.com/dfinity/ic-wasm/issues/65))
* [`c5217c76`](dfinity/ic-wasm@c5217c7) bump version ([dfinity/ic-wasm⁠#66](https://togithub.com/dfinity/ic-wasm/issues/66))
* [`c9439739`](dfinity/ic-wasm@c943973) fix memory id in limit_resource ([dfinity/ic-wasm⁠#67](https://togithub.com/dfinity/ic-wasm/issues/67))
* [`9293dfcc`](dfinity/ic-wasm@9293dfc) Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows ([dfinity/ic-wasm⁠#68](https://togithub.com/dfinity/ic-wasm/issues/68))
* [`085bbbff`](dfinity/ic-wasm@085bbbf) feat(EXC): Name Section for Metadata Command ([dfinity/ic-wasm⁠#69](https://togithub.com/dfinity/ic-wasm/issues/69))
* [`5fe03958`](dfinity/ic-wasm@5fe0395) chore: release v0.8.4 ([dfinity/ic-wasm⁠#70](https://togithub.com/dfinity/ic-wasm/issues/70))
* [`9f3c746e`](dfinity/ic-wasm@9f3c746) Fix http_request redirect ([dfinity/ic-wasm⁠#71](https://togithub.com/dfinity/ic-wasm/issues/71))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants