Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deduplicate two functions #4083

Merged
merged 2 commits into from
Jun 28, 2023
Merged

refactor: deduplicate two functions #4083

merged 2 commits into from
Jun 28, 2023

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Jun 28, 2023 •
edited
Loading

No functionality changes. Also some cosmetics in compile.ml.

@ggreif ggreif marked this pull request as ready for review June 28, 2023 07:27
@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Jun 28, 2023
luc-blaeser
luc-blaeser approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@luc-blaeser luc-blaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good.
(I also encountered this duplicate when I started porting to 64 bit.)

@github-actions
Copy link

Comparing from 6c64da4 to c37dacf:
The produced WebAssembly code seems to be completely unchanged.

@mergify mergify bot merged commit c09b751 into master Jun 28, 2023
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jun 28, 2023
@mergify mergify bot deleted the gabor/dedup branch June 28, 2023 09:09
crusso
crusso approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggreif ggreif mentioned this pull request Jun 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luc-blaeser luc-blaeser luc-blaeser approved these changes

@crusso crusso crusso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggreif @crusso @luc-blaeser