-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: repro and fix for issue #4267 (reject too long principals in Principal.fromBlob and actor literals) #4268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusso
changed the title
repro for issue #4267 (reject too long principals)
bugfix: repro and fix for issue #4267 (reject too long principals in Principal.fromBlob and actor literals)
Nov 6, 2023
crusso
commented
Nov 6, 2023
crusso
commented
Nov 6, 2023
...-drun/bad-actor-import/yvtf6-waaae-bagba-faydq-qcikb-mga2d-qpcai-reeyu-culbo-gazdi-nryhi.did
Outdated
Show resolved
Hide resolved
Part of me thinks it would have been cleaner just to remove the candid length check on deserialization and rely on the IC checking principal lengths... that would avoid changing the candid spec too.... |
nomeata
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #4267:
BREAKING CHANGE (Minor): values of type
Principal
are now constrained to containat most 29 bytes, matching the IC's notion of principal (bugfix: repro and fix for issue #4267 (reject too long principals in Principal.fromBlob and actor literals) #4268).
In particular:
An actor
import
will be statically rejected if the binary representation of the (aliased) textually encodedprincipal contains strictly more than 29 bytes.
Principal.fromBlob(b)
will trap ifb
contains strictly more than 29 bytes.The actor literal,
actor <exp>
, will trap if the binary representation ofof the textually encoded principal
<exp>
contains strictly more than 29 bytes.