Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify await.ml #4633

Merged
merged 16 commits into from
Jul 30, 2024
Merged

refactor: simplify await.ml #4633

merged 16 commits into from
Jul 30, 2024

Conversation

crusso
Copy link
Contributor

@crusso crusso commented Jul 26, 2024 •
edited by ggreif
Loading

Simple inspection reveals that we never add MetaCont to the context, which means we can simplify the code to enforce that invariant and consider fewer cases. This is an experiment to that effect, building on #4632.

@crusso crusso requested a review from ggreif July 26, 2024 11:52
@crusso crusso mentioned this pull request Jul 26, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 26, 2024 •
edited
Loading

Comparing from 75c59e1 to 6589cab:
The produced WebAssembly code seems to be completely unchanged.

@crusso crusso marked this pull request as ready for review July 26, 2024 12:49
@crusso crusso changed the base branch from claudio/finally-remix to master July 26, 2024 14:49
@crusso crusso changed the base branch from master to claudio/finally-remix July 26, 2024 14:51
@ggreif ggreif changed the title experiment: simplify await.ml experiment: simplify await.ml Jul 29, 2024
@crusso crusso changed the base branch from claudio/finally-remix to master July 30, 2024 12:48
@ggreif ggreif changed the title experiment: simplify await.ml chore: simplify await.ml Jul 30, 2024
ggreif
ggreif approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for cleaning up!

@ggreif ggreif changed the title chore: simplify await.ml refactor: simplify await.ml Jul 30, 2024
@crusso crusso added automerge-squash When ready, merge (using squash) and removed automerge-squash When ready, merge (using squash) labels Jul 30, 2024
@mergify mergify bot merged commit c7e5ac9 into master Jul 30, 2024
10 checks passed
@ggreif ggreif deleted the claudio/finally-simplified-context branch July 30, 2024 14:14
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jul 30, 2024
@ggreif ggreif mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreif ggreif ggreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusso @ggreif