-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invert public/private default #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusso
reviewed
Jul 16, 2019
crusso
reviewed
Jul 16, 2019
crusso
reviewed
Jul 16, 2019
crusso
reviewed
Jul 16, 2019
crusso
reviewed
Jul 16, 2019
crusso
reviewed
Jul 16, 2019
crusso
reviewed
Jul 16, 2019
crusso
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That must have been fun. EDIT: I noticed Syntax.md doesn't document the current module syntax and inlined (some of) the changes needed).
Did you update the guide? EDIT: I didn't see it in the list of files...
Co-Authored-By: Claudio Russo <claudio@dfinity.org>
Guide updated, PTAL. |
LGTM, thanks for fixing the slides too. |
chenyan-dfinity
pushed a commit
that referenced
this pull request
Jul 16, 2019
dfinity-bot
added a commit
that referenced
this pull request
Aug 28, 2024
## Changelog for candid: Branch: master Commits: [dfinity/candid@cfa7b54c...0ed73c14](dfinity/candid@cfa7b54...0ed73c1) * [`0ed73c14`](dfinity/candid@0ed73c1) Add size hints in order to optimize allocation during deserialization ([dfinity/candid#570](https://togithub.com/dfinity/candid/issues/570))
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
## Changelog for candid: Branch: master Commits: [dfinity/candid@cfa7b54c...0ed73c14](dfinity/candid@cfa7b54...0ed73c1) * [`0ed73c14`](dfinity/candid@0ed73c1) Add size hints in order to optimize allocation during deserialization ([dfinity/candid#570](https://togithub.com/dfinity/candid/issues/570))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes
private
the default visibility for object fields. To make up for that, thenew
syntax is now a separate short-hand record form, where only<id> = <exp>
syntax is allowed, and all fields are public. (In a future change I'd like to get rid of thenew
keyword for this, but that has various nasty grammar implications.)The tests, especially the produce-exchange, show that this inversion often leads to more verbose code, but I think we agree that it's still worth it. I also noted that the PX code makes a hell lot of things public...
Also, some minor grammar tweaks.