Ir: explicit NumConvPrim #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this extend the IR AST with that node. IR checker not (yet) extended. The transitition from Source (with untyped prims of arbitrary string) to IR (with a more structured AST) is a bit, eh, bumpy. But that might be fine, as this bumpyness only applies to code written in the sacred prelude.
|
Darn, can’t use regex functions from |
ggreif
approved these changes
Jul 26, 2019
There was a problem hiding this comment.
This looks very reasonable. I assume you mostly moved code around and massaging it mechanically to get from strings to pairs of types. Then the review burden should be rather small.
One thing that I just remembered, the function name_of_type should check if the last char is already a >, and then refrain from adding the angle brackets. Not necessarily in this PR, though.
Yeah. Lots of |
Co-Authored-By: Gabor Greif <ggreif@gmail.com>
dfinity-bot
added a commit
that referenced
this pull request
Nov 15, 2023
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@91466aa5...b28632e4](dfinity/motoko-base@91466aa...b28632e) * [`3d0bcedb`](dfinity/motoko-base@3d0bced) bugfix: Array.chain(as,f) incorrectly trapping when f(a) is an empty array. ([dfinity/motoko-base#599](https://togithub.com/dfinity/motoko-base/issues/599))
mergify bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
## Changelog for motoko-base: Branch: next-moc Commits: [dfinity/motoko-base@91466aa5...b28632e4](dfinity/motoko-base@91466aa...b28632e) * [`3d0bcedb`](dfinity/motoko-base@3d0bced) bugfix: Array.chain(as,f) incorrectly trapping when f(a) is an empty array. ([dfinity/motoko-base#599](https://togithub.com/dfinity/motoko-base/issues/599))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… instead of string-typed prim names.
This extends the IR AST with that node. IR checker not (yet) extended.
The transitition from Source (with untyped prims of arbitrary string) to
IR (with a more structured AST) is a bit, eh, bumpy. But that might be
fine, as this bumpyness only applies to code written in the sacred
prelude.