Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICRC account textual representation #2331

Merged
merged 4 commits into from
Apr 18, 2023
Merged

ICRC account textual representation #2331

merged 4 commits into from
Apr 18, 2023

Conversation

peterpeterparker
Copy link
Member

@peterpeterparker peterpeterparker commented Apr 18, 2023 •
edited
Loading

Motivation

Bump ic-js to implement what might be the definitive textual encoding for ICRC-1 account.

Source of encoding 👉 dfinity/ICRC-1#98

PRs

Changes

  • bump ic-js
  • test: fix mock data from / to that were incorrectly set
  • test: use object param to avoid from / to to be incorrectly set in the future
  • test: partial mock subaccount array isn't supported anymore to encode/decode ICRC account as the decoded checks the validity of the checksum

@peterpeterparker peterpeterparker added the feature request New feature or request label Apr 18, 2023
@peterpeterparker peterpeterparker added this pull request to the merge queue Apr 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2023
@peterpeterparker peterpeterparker added this pull request to the merge queue Apr 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2023
@peterpeterparker peterpeterparker added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 24d0824 Apr 18, 2023
@peterpeterparker peterpeterparker deleted the feat/icrc-textual branch April 18, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmuntaner lmuntaner lmuntaner approved these changes

Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterpeterparker @lmuntaner