feat: Set neuron visibility. #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s is not the latest, but is more recent. Trying to use the latest one gave me problems.
Anyway, a couple areas in our code then needed to be updated in response:
1. The way we explain proposals. This is implemented in src/lib/format/nns_governance.rs. (Having to hand craft humanization code does not seem very scalable. I think a better approach would be to instead just do format!("(:?}", proposal). This is maybe not as human-friendly, but it would never require us to hand craft humanization code.)
2. This resulted in some minor changes to the way the tool previews what the user is about to do (due to new optional fields), which then caused some tests to fail. Reworking those tests was fairly straight forward, compared to the hand-crafted code needed to support proposal humanization. This is (probably) a well-known weakness in our testing strategy here.
Also, I added a script that updates Cargo.toml (and Cargo.lock), and the candid directory. I then used this to update the candid directory. (I had already updated Cargo.toml by hand, but this could have been used to update Cargo.toml as well.)
…lags section. Seems like someone may have mistakenly started a separate section (either Flags already existed, and Options was later added, or the other way around). The two should really just be one, because when you do `quill neuron-manage --help, it lists the flags described in the erstewhile two sections.
…alled "bats"), but GitHub knows, so I will push this to find out if my changes are correct.
adamspofford-dfinity
requested changes
Aug 16, 2024
| /// arbitrary principal can view all fields of the neuron (Public), or just | ||
| /// a limited subset (Private). | ||
| #[arg(long)] | ||
| set_visibility: Option<NativeVisibility>, |
There was a problem hiding this comment.
Since this is not supported in the Ledger app, it should be added to the incompatibility list.
There was a problem hiding this comment.
How do I do that?
There was a problem hiding this comment.
See the top line of the function. Add it to the && list.
There was a problem hiding this comment.
Done.
I guess you mean in the exec function, since this line is not in a function.
| /// arbitrary principal can view all fields of the neuron (Public), or just | ||
| /// a limited subset (Private). | ||
| #[arg(long)] | ||
| set_visibility: Option<NativeVisibility>, |
There was a problem hiding this comment.
How do I do that?
adamspofford-dfinity
approved these changes
Aug 21, 2024
adamspofford-dfinity
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
--set-visibilityflag toquill neuron-manage. Takes one of two possible values:publicorprivate.In a separate commit, updated this repo to point to a more recent commit in the ic repo.
Added a script to make the aforementioned chore easier.
Closes NNS1-3275.
How Has This Been Tested?
Added set_visibility test.
Checklist