New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dfx: asset media type identification: fall back to check contents #1594

Closed

ericswanson-dfinity opened this issue Apr 13, 2021 · 1 comment

Member

ericswanson-dfinity commented Apr 13, 2021

Rather than immediately falling back to application/octet-stream, use the magic library or something like it to try to determine the media type.

The magic library requires a database, which would have to be distributed with dfx. In earlier testing, without a database, it misidentified our new project .js files as application/x-perl.

The text was updated successfully, but these errors were encountered:

Contributor

sesi200 commented Oct 4, 2022

Closing this as stale. @ericswanson-dfinity if this is still a thing to do, please re-file this as a Jira ticket.

sesi200 closed this as completed

dfinity-bot added a commit that referenced this issue


          build: niv advisory-db: update bb92d2d5 -> b485cf4d

416d4d2

## Changelog for advisory-db:
Branch: main
Commits: [rustsec/advisory-db@bb92d2d5...b485cf4d](rustsec/advisory-db@bb92d2d...b485cf4)

* [`58e20bb7`](rustsec/advisory-db@58e20bb) Add CVE-2023-0286 for openssl-src ([RustSec/advisory-db⁠#1573](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1573))
* [`56f79c7b`](rustsec/advisory-db@56f79c7) Assigned RUSTSEC-2023-0006 to openssl-src ([RustSec/advisory-db⁠#1574](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1574))
* [`a0530f10`](rustsec/advisory-db@a0530f1) Add CVE-2022-4304 for openssl-src ([RustSec/advisory-db⁠#1575](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1575))
* [`d70e7f95`](rustsec/advisory-db@d70e7f9) Assigned RUSTSEC-2023-0007 to openssl-src ([RustSec/advisory-db⁠#1576](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1576))
* [`4bf8b4c3`](rustsec/advisory-db@4bf8b4c) Add CVE-2022-4203 for openssl-src ([RustSec/advisory-db⁠#1577](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1577))
* [`8d1c5992`](rustsec/advisory-db@8d1c599) Assigned RUSTSEC-2023-0008 to openssl-src ([RustSec/advisory-db⁠#1578](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1578))
* [`818cdec0`](rustsec/advisory-db@818cdec) Add CVE-2023-0215 for openssl-src ([RustSec/advisory-db⁠#1579](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1579))
* [`b324cf92`](rustsec/advisory-db@b324cf9) Assigned RUSTSEC-2023-0009 to openssl-src ([RustSec/advisory-db⁠#1581](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1581))
* [`1445e637`](rustsec/advisory-db@1445e63) Add CVE-2022-4450 for openssl-src ([RustSec/advisory-db⁠#1580](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1580))
* [`94fdfaf7`](rustsec/advisory-db@94fdfaf) Assigned RUSTSEC-2023-0010 to openssl-src ([RustSec/advisory-db⁠#1585](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1585))
* [`3e3631fd`](rustsec/advisory-db@3e3631f) Add CVE-2023-0216 for openssl-src ([RustSec/advisory-db⁠#1582](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1582))
* [`19c2e8af`](rustsec/advisory-db@19c2e8a) Assigned RUSTSEC-2023-0011 to openssl-src ([RustSec/advisory-db⁠#1586](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1586))
* [`3cfb8970`](rustsec/advisory-db@3cfb897) Add CVE-2023-0217 for openssl-src ([RustSec/advisory-db⁠#1583](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1583))
* [`daa52cad`](rustsec/advisory-db@daa52ca) Assigned RUSTSEC-2023-0012 to openssl-src ([RustSec/advisory-db⁠#1587](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1587))
* [`0f3d1597`](rustsec/advisory-db@0f3d159) Add CVE-2023-0401 for openssl-src ([RustSec/advisory-db⁠#1584](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1584))
* [`feb5cddd`](rustsec/advisory-db@feb5cdd) Assigned RUSTSEC-2023-0013 to openssl-src ([RustSec/advisory-db⁠#1588](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1588))
* [`c6193701`](rustsec/advisory-db@c619370) Add advisory aliyun-oss-client ([RustSec/advisory-db⁠#1589](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1589))
* [`8a1400e3`](rustsec/advisory-db@8a1400e) Assigned RUSTSEC-2022-0089 to aliyun-oss-client ([RustSec/advisory-db⁠#1590](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1590))
* [`cb6cfde9`](rustsec/advisory-db@cb6cfde) Update RUSTSEC-2020-0071.md ([RustSec/advisory-db⁠#1591](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1591))
* [`b485cf4d`](rustsec/advisory-db@b485cf4) Update RUSTSEC-2020-0071.md ([RustSec/advisory-db⁠#1594](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1594))

mergify bot pushed a commit that referenced this issue


          build: niv advisory-db: update bb92d2d5 -> b485cf4d (#2956)

4461fd3

## Changelog for advisory-db:
Branch: main
Commits: [rustsec/advisory-db@bb92d2d5...b485cf4d](rustsec/advisory-db@bb92d2d...b485cf4)

* [`58e20bb7`](rustsec/advisory-db@58e20bb) Add CVE-2023-0286 for openssl-src ([RustSec/advisory-db⁠#1573](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1573))
* [`56f79c7b`](rustsec/advisory-db@56f79c7) Assigned RUSTSEC-2023-0006 to openssl-src ([RustSec/advisory-db⁠#1574](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1574))
* [`a0530f10`](rustsec/advisory-db@a0530f1) Add CVE-2022-4304 for openssl-src ([RustSec/advisory-db⁠#1575](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1575))
* [`d70e7f95`](rustsec/advisory-db@d70e7f9) Assigned RUSTSEC-2023-0007 to openssl-src ([RustSec/advisory-db⁠#1576](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1576))
* [`4bf8b4c3`](rustsec/advisory-db@4bf8b4c) Add CVE-2022-4203 for openssl-src ([RustSec/advisory-db⁠#1577](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1577))
* [`8d1c5992`](rustsec/advisory-db@8d1c599) Assigned RUSTSEC-2023-0008 to openssl-src ([RustSec/advisory-db⁠#1578](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1578))
* [`818cdec0`](rustsec/advisory-db@818cdec) Add CVE-2023-0215 for openssl-src ([RustSec/advisory-db⁠#1579](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1579))
* [`b324cf92`](rustsec/advisory-db@b324cf9) Assigned RUSTSEC-2023-0009 to openssl-src ([RustSec/advisory-db⁠#1581](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1581))
* [`1445e637`](rustsec/advisory-db@1445e63) Add CVE-2022-4450 for openssl-src ([RustSec/advisory-db⁠#1580](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1580))
* [`94fdfaf7`](rustsec/advisory-db@94fdfaf) Assigned RUSTSEC-2023-0010 to openssl-src ([RustSec/advisory-db⁠#1585](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1585))
* [`3e3631fd`](rustsec/advisory-db@3e3631f) Add CVE-2023-0216 for openssl-src ([RustSec/advisory-db⁠#1582](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1582))
* [`19c2e8af`](rustsec/advisory-db@19c2e8a) Assigned RUSTSEC-2023-0011 to openssl-src ([RustSec/advisory-db⁠#1586](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1586))
* [`3cfb8970`](rustsec/advisory-db@3cfb897) Add CVE-2023-0217 for openssl-src ([RustSec/advisory-db⁠#1583](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1583))
* [`daa52cad`](rustsec/advisory-db@daa52ca) Assigned RUSTSEC-2023-0012 to openssl-src ([RustSec/advisory-db⁠#1587](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1587))
* [`0f3d1597`](rustsec/advisory-db@0f3d159) Add CVE-2023-0401 for openssl-src ([RustSec/advisory-db⁠#1584](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1584))
* [`feb5cddd`](rustsec/advisory-db@feb5cdd) Assigned RUSTSEC-2023-0013 to openssl-src ([RustSec/advisory-db⁠#1588](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1588))
* [`c6193701`](rustsec/advisory-db@c619370) Add advisory aliyun-oss-client ([RustSec/advisory-db⁠#1589](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1589))
* [`8a1400e3`](rustsec/advisory-db@8a1400e) Assigned RUSTSEC-2022-0089 to aliyun-oss-client ([RustSec/advisory-db⁠#1590](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1590))
* [`cb6cfde9`](rustsec/advisory-db@cb6cfde) Update RUSTSEC-2020-0071.md ([RustSec/advisory-db⁠#1591](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1591))
* [`b485cf4d`](rustsec/advisory-db@b485cf4) Update RUSTSEC-2020-0071.md ([RustSec/advisory-db⁠#1594](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1594))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment