Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFX should report its version based on what is installed, not dfx.json #474

Closed
hansl opened this issue Mar 20, 2020 · 1 comment
Closed

DFX should report its version based on what is installed, not dfx.json #474

hansl opened this issue Mar 20, 2020 · 1 comment

Comments

@hansl
Copy link
Contributor

hansl commented Mar 20, 2020

We have some work for this, but not enough. There should be a dfx version that shows version installed, defined in the project, and latest in the cache.
@p-shahi
Copy link
Contributor

p-shahi commented Feb 16, 2021

addressed in #1397

@p-shahi p-shahi closed this as completed Feb 16, 2021
dfinity-bot added a commit that referenced this issue Oct 19, 2021
@dfinity-bot
build: niv common: update 7750d6b2 -> 8fd13772
e7af2b2 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@7750d6b2...8fd13772](https://github.com/dfinity-lab/common/compare/7750d6b286d396e87ed6b01e6c8cffa4e7ea9e86...8fd13772016f9273a3ce61efa77b9f6a3345a67a)

* [`8fd13772`](https://github.com/dfinity-lab/common/commit/8fd13772016f9273a3ce61efa77b9f6a3345a67a) Fix Arshavir's public key ([dfinity-lab/common⁠#474](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/474))
mergify bot pushed a commit that referenced this issue Oct 19, 2021
@dfinity-bot
build: niv common: update 7750d6b2 -> 8fd13772 (#1882)
984815d 
## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@7750d6b2...8fd13772](https://github.com/dfinity-lab/common/compare/7750d6b286d396e87ed6b01e6c8cffa4e7ea9e86...8fd13772016f9273a3ce61efa77b9f6a3345a67a)

* [`8fd13772`](https://github.com/dfinity-lab/common/commit/8fd13772016f9273a3ce61efa77b9f6a3345a67a) Fix Arshavir's public key ([dfinity-lab/common⁠#474](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/474))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hansl @p-shahi