-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A developer can pass data as part of an installation #477
Comments
Although need is a strong word. For now, Motoko doesn’t use this feature of the system, so one could argue that |
Since |
Agreed. The same feature was requestd for |
An external user (Norton Wang) also requested it here: https://forum.dfinity.org/t/canister-installation-arguments/1254 |
I wonder whether the 2 requests were somehow linked :) |
No way! |
#1038 works for single canister install. I want to discuss how to extend this to
With this feature, we are starting to have one-to-many mapping from wasm module to canisters, e.g., I can create several counter canisters with different initial values:
And I should get three canister ids associated with the For my PR, I will just handle the single canister install with only one canister id case, and let the team decide how to support the more general case. WDYT? |
This PR only supports install arguments for a single canister with one canister id. The remaining cases are discussed in #477
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@202265fb...0bdef412](rustsec/advisory-db@202265f...0bdef41) * [`5eb66747`](rustsec/advisory-db@5eb6674) Unexpected panic in multihash `from_slice` parsing code ([RustSec/advisory-db#475](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/475)) * [`0ca360b1`](rustsec/advisory-db@0ca360b) Assigned RUSTSEC-2020-0068 to multihash ([RustSec/advisory-db#476](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/476)) * [`0bdef412`](rustsec/advisory-db@0bdef41) RUSTSEC-2020-0068: remove parameters from affected functions ([RustSec/advisory-db#477](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/477))
## Changelog for advisory-db: Branch: master Commits: [rustsec/advisory-db@202265fb...0bdef412](rustsec/advisory-db@202265f...0bdef41) * [`5eb66747`](rustsec/advisory-db@5eb6674) Unexpected panic in multihash `from_slice` parsing code ([RustSec/advisory-db#475](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/475)) * [`0ca360b1`](rustsec/advisory-db@0ca360b) Assigned RUSTSEC-2020-0068 to multihash ([RustSec/advisory-db#476](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/476)) * [`0bdef412`](rustsec/advisory-db@0bdef41) RUSTSEC-2020-0068: remove parameters from affected functions ([RustSec/advisory-db#477](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/477))
part of this is done but the second half should be addressed with #1692 |
The public spec supports an
arg
argument of type Blob during aninstall
request. We need to support this in the CLI as well.The text was updated successfully, but these errors were encountered: