feat: sign request_status for update call #1676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-shahi
suggested changes
May 20, 2021
|
Block by dfinity/agent-rs#182 |
p-shahi
approved these changes
May 24, 2021
lwshang
commented
May 24, 2021
| let envelope = hex::decode(&message.signed_request_status.unwrap())?; | ||
| let response = transport.read_state(canister_id.clone(), envelope).await?; | ||
| let read_state_response: ReadStateResponse = serde_cbor::from_slice(&response)?; | ||
| let certificate: Certificate = serde_cbor::from_slice(&read_state_response.certificate)?; |
There was a problem hiding this comment.
@hansl Here is the usage of Certificate. It does a deserialization from CBOR response.
This reverts commit cf9b740.
dfinity-bot
added a commit
that referenced
this pull request
Apr 9, 2023
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@6078097f...e6600338](rustsec/advisory-db@6078097...e660033) * [`e6600338`](rustsec/advisory-db@e660033) Withdraw RUSTSEC-2021-0147 ([RustSec/advisory-db#1676](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1676))
mergify bot
pushed a commit
that referenced
this pull request
Apr 9, 2023
## Changelog for advisory-db: Branch: main Commits: [rustsec/advisory-db@6078097f...e6600338](rustsec/advisory-db@6078097...e660033) * [`e6600338`](rustsec/advisory-db@e660033) Withdraw RUSTSEC-2021-0147 ([RustSec/advisory-db#1676](http://r.duckduckgo.com/l/?uddg=https://github.com/RustSec/advisory-db/issues/1676))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close dfinity/dx-triage#156
Current implementation for
sign/sendsegregation is a hack which "hijacks" thetransportof theagent. Because inagent-rs, we only publish the top layer interface which make it hard to get intermediate stages of a update/query call.In consequence, the
responsefromsign/sendcannot be handled as well as incanister call. We have to print the CBOR response naively and let users to investigate using cbor.me.To make
sign/senduser friendly, we need a refactor inagent-rs.