Dfx 15 #262
Merged
Dfx 15 #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitdivine
added a commit
that referenced
this pull request
Nov 10, 2023
# Motivation In `dfx v0.14.4`, `dfx nns deploy` would create the `internet_identity` and `nns-dapp` canisters with the current user as the controller. In `dfx v0.15.1` the anonymous user is the controller, which is a breaking change. # Changes - Check whether the current user is a controller and if not, use the anonymous user to add the current user as a controller. # Tests - For `dfx v0.14.4` see CI in the current PR. - For `dfx v0.15.1` see [the PR that updates `dfx` to `v0.51.1`](#262). --------- Co-authored-by: Max Murphy <max@winning.black> Co-authored-by: Formatting Committer <nobody@example.com>
1 task
bitdivine
added a commit
that referenced
this pull request
Nov 17, 2023
This reverts commit b051ff0.
bitdivine
added a commit
that referenced
this pull request
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We would like to keep
dfxup to date.Changes
dfxfrom version0.14.4to0.15.1dfx nnsas an extension, as it is no longer indfxcore.Tests