Added compatibility with MSVC on Windows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added translations for some new API types from V8 5.5+ Changed v8-glue.cc to avoid C99 features that MSVC does not support
Current coverage is 89.41% (diff: 100%)@@ master #2 diff @@
==========================================
Files 10 10
Lines 652 652
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 583 583
Misses 69 69
Partials 0 0
|
dflemstr
requested changes
Oct 4, 2016
| if cfg!(all(windows, target_env="msvc")) { | ||
| println!("cargo:rustc-link-lib=dylib=v8.dll"); | ||
| println!("cargo:rustc-link-lib=static=v8_base"); | ||
| println!("cargo:rustc-link-lib=static=v8_platform"); |
There was a problem hiding this comment.
Actually I don't think v8_platform is needed. We don't link it in the Linux static build.
There was a problem hiding this comment.
I think it may be from using GN to build v8 on windows, but it built both. I can link them together though so I'll go ahead and remove this.
There was a problem hiding this comment.
So v8_platform is needed if you don't implement your own, which we do through the PlatformFunctions API towards Rust.
| @@ -899,11 +900,11 @@ ValueRef v8_Object_CallAsFunction(RustContext c, ObjectRef self, ContextRef cont | |||
| v8::HandleScope scope(c.isolate); | |||
| v8::TryCatch try_catch(c.isolate); | |||
| v8::Context::Scope context_scope(wrap(c.isolate, context)); | |||
| v8::Local<v8::Value> argv_wrapped[argc]; | |||
| std::vector<v8::Local<v8::Value>> argv_wrapped(argc); | |||
There was a problem hiding this comment.
It would be so nice to not heap allocate here but I guess we have no choice with portable C++ so 👍
Removed build step linking v8_platform.lib on windows to match linking on linux
dflemstr
approved these changes
Oct 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added translations for some new API types from V8 5.5+
Changed v8-glue.cc to avoid C99 features that MSVC does not support