Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidify blobs dtype inference #363

Merged
merged 5 commits into from Sep 19, 2020
Merged

Solidify blobs dtype inference #363

merged 5 commits into from Sep 19, 2020

Conversation

aarchiba
Copy link
Contributor

Reduce the chance of user surprise due to blob dtype inference - strings are object dtypes, object dtypes don't lead to backend weirdness, ragged blob dtypes raise numpy.VisibleDeprecationWarning unless blobs_dtype is specified. Also fixes problems where grow used to re-infer blob dtypes.

Closes #361

@dfm
Copy link
Owner

dfm commented Aug 27, 2020

This looks great!

Like you suggested in #361, perhaps we should catch the cases where this deprecation hits and a user hasn't provided a blobs_dtype and provide a recommendation? Happy to merge this and open a separate issue if you think that's best.

Thanks!!

@aarchiba
Copy link
Contributor Author

https://numpy.org/neps/nep-0034-infer-dtype-is-object.html specifies the deprecation process, so the same change should allow transforming the ValueError into a more informative one as well, for users with a whiz-bang future version of numpy that does that.

@aarchiba
Copy link
Contributor Author

aarchiba commented Sep 2, 2020

Ready for review.

@dfm
Copy link
Owner

dfm commented Sep 10, 2020

Sorry I've been slow to respond - this week has been crazy! I'll get back here in the next few days.

@dfm
Copy link
Owner

dfm commented Sep 19, 2020

Sorry about the delay! I think this looks great and I'm happy to merge. Thanks for this! I'll start a new pull request thread to draft a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emits numpy deprecation warning about ragged sequences
2 participants