Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build-requirements with pyproject.tml (no prior manual install of numpy & pybind11) #124

Conversation

FelixKleineBoesing
Copy link

  • installing george via pip is now possible without prior installation of numpy and pybind11
  • pybind11 v2.4.3 doesn´t support this build possibilty since the function get_include always points to the location where the header files are located when it´s installed. Since the package is located in a temporary build directory during the build process, the header files couldn´t be found. The recent master version of pybind11 has a new get_include function that is similar to numpy´s version and enables build requirements. Nevertheless, after the build process, the released 2.4.3 pybind11 version will be used.
  • for now a specific master commit is referenced inside pyproject.toml, but that should be changed to the next tagged version. tests are all working under macos and ubuntu (dockerfile is added to root directory)

- installing george via pip is now possible without prior installation of numpy and pybind11
- pybind11 v2.4.3 doesn´t support this build possibilty since the function get_include always points to the location where the header files are located when it´s installed. Since the package is located in a temporary build directory during the build process, the header files couldn´t be found. The recent master version of pybind11 has a new get_include function that is similar to numpy´s version and enables build requirements. Nevertheless, after the build process, the released 2.4.3 pybind11 version will be used.
- for now a specific master commit is referenced inside pyproject.toml, but that should be changed to the next tagged version. tests are all working under macos and ubuntu (dockerfile is added to root directory)
@coveralls
Copy link

coveralls commented Jan 10, 2020

Coverage Status

Coverage remained the same at 85.486% when pulling db6fc25 on FelixKleineBoesing:feature/build-requirements into 4481968 on dfm:master.

@dfm
Copy link
Owner

dfm commented Jan 13, 2020

Thanks for this! Can you send a link to the discussion of this feature on the pybind11 repo so we can keep an eye on it?

@FelixKleineBoesing
Copy link
Author

FelixKleineBoesing commented Jan 13, 2020

Hi Dan,
this is the discussion to the mentioned changes in pybind11: pybind/pybind11#1995

@FelixKleineBoesing
Copy link
Author

This problem is fixed with version v2.5.0 of pybind11.

@dfm
Copy link
Owner

dfm commented Feb 15, 2021

I've finally fixed this in #140. Thanks!

@dfm dfm closed this Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants