Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to make CARMA kernel jit-compliant #188

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

dhuppenkothen
Copy link
Contributor

@dhuppenkothen dhuppenkothen commented Oct 4, 2023

I'm currently trying to get the CARMA model working with JaxNS, and am running into jit-compiler issues that I've tracked down to the different behaviour between jax.numpy.roots and numpy.roots, and the use of the numpy roll function.

These seem like small fixes, but I won't pretend I really understand either JAX jit or tinygp in enough detail to know whether it breaks anything.

Looking at the issues (which I guess I should have done before), it looks like I'm not the first person to find this error (cf #89), but I don't know if #90 will solve this issue (or what the current status of this PR is?)

@dfm
Copy link
Owner

dfm commented Oct 4, 2023

Thanks! I think #90 won't have this issue, and I'd love to get that working whenever @ywx649999311 gets a chance to revisit it! However, I'm happy to merge this in the meantime as a band-aid fix.

@dfm
Copy link
Owner

dfm commented Oct 4, 2023

In the meantime, @dhuppenkothen can you:

  1. Add a file called news/188.bugfix that describes this fix in a single line. See the changelog for examples - each bullet point was generated from one of these files.
  2. Add your info to .zenodo.json so that you'll be included as an author on the next release.

Thanks!

@dfm dfm merged commit 3c338bf into dfm:main Oct 5, 2023
8 of 9 checks passed
@ywx649999311
Copy link
Contributor

Thanks! I think #90 won't have this issue, and I'd love to get that working whenever @ywx649999311 gets a chance to revisit it! However, I'm happy to merge this in the meantime as a band-aid fix.

Hi @dfm, I am currently in the middle of moving between countries for my new job. I will make this the number one priority once I settle down, but it won't be until the 23rd. I am sorry for the long delay.

@dfm
Copy link
Owner

dfm commented Oct 7, 2023

Absolutely no stress, @ywx649999311!! Looking forward to checking back in whenever you're ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants