Attempt to make CARMA kernel jit-compliant #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently trying to get the CARMA model working with JaxNS, and am running into jit-compiler issues that I've tracked down to the different behaviour between
jax.numpy.roots
andnumpy.roots
, and the use of the numpyroll
function.These seem like small fixes, but I won't pretend I really understand either JAX jit or tinygp in enough detail to know whether it breaks anything.
Looking at the issues (which I guess I should have done before), it looks like I'm not the first person to find this error (cf #89), but I don't know if #90 will solve this issue (or what the current status of this PR is?)