Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom databox directory ignored #1

Closed
drudv opened this issue Feb 9, 2018 · 2 comments
Closed

Custom databox directory ignored #1

drudv opened this issue Feb 9, 2018 · 2 comments

Comments

@drudv
Copy link
Contributor

drudv commented Feb 9, 2018 •
edited
Loading

Having

$dataBox = new DataBox('/my/custom/data-box');

files are being saved to the root and the provided custom directory path is ignored. Looks like it is not even stored in directory property of DataBox here:

CzechDataBox/src/DataBox.php

Line 68 in 05e03b3

if ($directory === null) {

@dfridrich
Copy link
Owner

Hi, can you provide fix?

@drudv drudv mentioned this issue Feb 9, 2018
Merged
@drudv
Copy link
Contributor Author

drudv commented Feb 9, 2018 •
edited
Loading

I've just sent a PR #2 with the simple fix, that resolves my problem. Please take a look.

@AlkoKod AlkoKod mentioned this issue Jul 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dfridrich @drudv