-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalise tasks #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew execute function); Nearly complete; Not tested!"
…e-tasks, dftbutils-tasks and user-defined-task
…deprecation; tested OK
…, and user-tasks; Untested
…of Bugsgit status!
…ly to be discarded in future
…n evaluate due to DataBase being exchanged at call time; This shall enable skpar to run again
…andindex returned default to true
…y to enable legacy handling of model DB; most tests pass and test_optimise.yaml works!
…e, and is passed to Objective.get() so that evaluation can now really be performed in parallel for several iterations at a time; all tests pass and skpar_*yaml run OK
…nd GetTasks as these are non-existent anymore
…ct; Tasks and tests that need database are now using only get() and update() and can operate with a python dict as opposed to an instance of the Database class. The Database class will likely evaporate together with the Query, when Objectives are re-worked
…f electronic structure; plot_bs still fails somehow
…o be saved; Assertion to catch user-input mistakes leading to lack of data to plot
…ename; reworked a bit how plot title and filename are established
…ed to evol.py and plotting improved; Added __repr__() to core.database.Query; Repulsive Fit example fixed for current task interface and added plot task
…example is executable
…plicit task selection; unit-tested:OK; affected input files have not been updated however
…upplied; removed spurious file test.py from skpar/core
… tasks from user modules
…ch is mandatory in order to help debugging yaml issues
…bugs in dftbutils.utils – spuriously messed up function declaration and workdir assignment for execute()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implemented tasks:
Major files affected:
usertasks.py (new), tasks.py, evaluate.py, taskdict.py
Minor changes:
input.py, skpar.py, optimise.py
Other minor changes - to adapt call signatures:
dftbutils.queryDFTB.py, dftbutils.taskdict.py (new)