Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexibility of subcommands #43

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Conversation

vanderhe
Copy link
Member

@vanderhe vanderhe commented Jan 27, 2023

Establishes two generalizations:

  • allow for negative CAM-alpha and -beta values (necessary for SRSH-functionals)
  • make maximum number of SCF steps and SCF convergence tolerance accessible from the user's perspective (skdef.hsd)
OnecenterParameters {

  C {
    .
    Calculator = SlaterAtom {
      MaxSCFIterations = 30       # default: 120
      SCFTolerance = 1e-08        # default: 1e-10 a.u.
      .
      .
      }
    }
  }
}

Builds upon #40, therefore ideally to be merged afterwards.
Closes #45.
Closes #46.

@vanderhe vanderhe added the enhancement New feature or request label Jan 27, 2023
@vanderhe vanderhe requested a review from aradi January 27, 2023 09:06
@vanderhe vanderhe changed the title Improves flexibility of subcommands Improve flexibility of subcommands Jan 27, 2023
@aradi
Copy link
Member

aradi commented Feb 1, 2023

Very good idea! I am absolutely fine with this PR. Could you rebase and squash it, and then I'll merge.

@vanderhe
Copy link
Member Author

vanderhe commented Feb 2, 2023

Very good idea! I am absolutely fine with this PR. Could you rebase and squash it, and then I'll merge.

@aradi Thx, rebased on main and ready to go from my side. Shall I still squash the remaining two commits into one? Since they are dealing with two disjoint features.

@aradi aradi merged commit b2ab60c into dftbplus:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants