Remove dead link and update outdated link #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfunckt
reviewed
Apr 28, 2019
There was a problem hiding this comment.
Thanks for the PR!
I'm fairly certain the internal link used to work before -- the blank .. _authorization in Django: syntax used to create an anchor we could link to -- but apparently not anymore. Its purpose was to link to the Using Rules with Django headline and I think it's a useful cross-reference to preserve, hence my comment.
| @@ -201,7 +201,7 @@ Predicates can do pretty much anything with the given arguments, but must | |||
| always return ``True`` if the condition they check is true, ``False`` | |||
| otherwise. ``rules`` comes with several predefined predicates that you may | |||
| read about later on in `API Reference`_, that are mostly useful when dealing | |||
| with `authorization in Django`_. | |||
| with authorization in Django. | |||
There was a problem hiding this comment.
Can you please make this point to the Using Rules with Django headline?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.