This repository has been archived by the owner on Feb 19, 2020. It is now read-only.
feature(streamer): POC of streamer layer and project reorg #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexCppns
force-pushed
the
eosws-migration
branch
from
c463d47
to
746d83b
Compare
maoueh
suggested changes
Nov 1, 2018
| @@ -6,9 +6,9 @@ | |||
| "types": "index.d.js", | |||
| "files": [ | |||
| "index.js", | |||
| "index.d.ts", | |||
| "types" | |||
There was a problem hiding this comment.
Removing this will cause the publish to not include them in the package, which is not what is expected.
package.json
Outdated
| ], | ||
| "bin": "dist", |
There was a problem hiding this comment.
In fact, I see you changed the source files and their output directory. Probably something related to that caused the bad publish.
Will need to check that before merging.
maoueh
approved these changes
Nov 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
@dfusenamespace in package name.