Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translator: added support for enums #412

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Translator: added support for enums #412

merged 1 commit into from
Jan 18, 2022

Conversation

drobek94
Copy link
Contributor

No description provided.

@milo
Copy link
Collaborator

milo commented Jan 13, 2022

See #408

@drobek94
Copy link
Contributor Author

See #408

In #408 change it's not allowed used modifier. If the IF-section will move up (like my change), it will be allowed.

@drobek94
Copy link
Contributor Author

For example:
$database->query('SELECT * FROM table WHERE enum_column = %s', MyEnum::case)
ends with:
SQL translate error: Invalid combination of type MyEnum and modifier %s

@dg
Copy link
Owner

dg commented Jan 18, 2022

Thaks

@dg dg changed the title Translator update for enums support Translator: added support for enums Jan 18, 2022
@dg dg merged commit 609fcce into dg:master Jan 18, 2022
dg pushed a commit that referenced this pull request Jan 18, 2022
@milo @dg
Translator: convert BackedEnum to scalar
04bb5ed 
also closes (#412)
Jakub-Fajkus pushed a commit to peckadesign/dibi that referenced this pull request Feb 9, 2022
@milo @Jakub-Fajkus
Translator: convert BackedEnum to scalar
98e59e4 
also closes (dg#412)

(cherry picked from commit 04bb5ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drobek94 @milo @dg