Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAIT technique bugfix #88

Merged
merged 3 commits into from
Oct 7, 2022
Merged

WAIT technique bugfix #88

merged 3 commits into from
Oct 7, 2022

Conversation

vetschn
Copy link
Contributor

@vetschn vetschn commented Oct 6, 2022

This addresses the E_range bug for the WAIT technique #87.

@PeterKraus
Copy link
Contributor

PeterKraus commented Oct 6, 2022 •
edited
Loading

Thanks.

@PeterKraus
Copy link
Contributor

For the record, I think there are three options how to handle this case: NaN, +/-inf, or None. While NaN or None may be a little more consistent with there not being an actual value, setting the limits to infinity keeps the rest of the code unchanged and is probably more suitable for a backport.

@PeterKraus PeterKraus merged commit a0eaf34 into dgbowl:master Oct 7, 2022
PeterKraus pushed a commit that referenced this pull request Oct 7, 2022
@vetschn @PeterKraus
WAIT technique bugfix (#88)
0545dae 
* Bugfix

* Properly defaulting E_range

* Testing

Co-authored-by: Nicolas Vetsch <vetschn@student.ethz.ch>
@PeterKraus PeterKraus mentioned this pull request Oct 7, 2022
Closed
PeterKraus pushed a commit that referenced this pull request Oct 7, 2022
@vetschn @PeterKraus
WAIT technique bugfix (#88)
0e8c911 
* Bugfix

* Properly defaulting E_range

* Testing

Co-authored-by: Nicolas Vetsch <vetschn@student.ethz.ch>
@JAC28 JAC28 mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vetschn @PeterKraus