Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

templateBasePath requires closing slash #55

Closed
oskarrough opened this issue Nov 30, 2013 · 2 comments · Fixed by #57
Closed

templateBasePath requires closing slash #55

oskarrough opened this issue Nov 30, 2013 · 2 comments · Fixed by #57

Comments

@oskarrough
Copy link

In case someone runs into the same issue, my templates weren't compiling as I didn't have an ending / in my path. Not sure if this is the way it's supposed to be or an issue. Feel free to close.

works:

templateBasePath: '<%= yeoman.app %>/scripts/templates/'

does not work:

templateBasePath: '<%= yeoman.app %>/scripts/templates'

@rwjblue
Copy link
Contributor

rwjblue commented Dec 2, 2013

It seems from reading the source (here) that the templates should be generated regardless of what you use in templateBasePath. The issue is likely that it was only removing app/scripts/templates which left your templates registered with a leading slash.

In other words a file named app/scripts/templates/foo.hbs would be compiled and registered as a module named /foo (assuming a templateBasePath of app/scripts/templates).

I have submitted #57 to help prevent this situation in the future.

@dgeb dgeb closed this as completed in 64a2753 Dec 4, 2013
@oskarrough
Copy link
Author

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants