JSON body is not decoded when Content-Type: application/json is not present

[derlaft]

Thus, I think this is logical to decode JSON whether header is set or not, because user must explicitly pass successV/failureV.

Broken test defines current behaviour, If you agree I will fix it too.

[dghubble]

Receive(successV, failureV interface) and Receive(successV interface{}) decode JSON responses into the given structs. The status code (200-299 vs other) determines which struct to decode into. JSON responses should have a ContentType: "application/json", this is an intentional check.

You may look into why the API does not set the ContentType correctly. Some Facebook API endpoints do this incorrectly (using text/javascript instead), so setting the accept header is required to get proper responses. https://github.com/dghubble/gologin/blob/master/facebook/verify.go#L38 Perhaps a similar option is available to you.

[derlaft]

@dghubble My server app ignores Accept header and always answers with 'Content-Type: text/plain'

JSON responses should have a ContentType: application/json, this is an intentional check.

Why should they? It's clients that are developed for use with servers, not the opposite. I wish I lived in the universe where every server cares about Content-Type header.

[dghubble]

Why should they?

https://tools.ietf.org/html/rfc7159

Is your server app one you can correct or is it a well known service? I'm curious what is returning that. I can see a case for allowing text/javascript since its such a common mistake. Perhaps for accommodating all bad actors, though its a few lines to write the decoder you need.