Save response body when parsing JSON #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the json decoder consumes the reader and there are cases where we want to preserve the response body to further process outside sling a flag to restore it has been included
|
@dghubble any chance of getting this merged? |
dghubble
reviewed
May 24, 2018
| // Read the content | ||
| var bodyBytes []byte | ||
| if resp.Body != nil { | ||
| bodyBytes, _ = ioutil.ReadAll(resp.Body) |
There was a problem hiding this comment.
should never be needed in a response handling library
|
If the desire is to parse the response directly, its best to just parse the response directly. No need to shoehorn the "save response" case alongside the convenience JSON object decoders. If any additional features are added to sling, the decoder proposal has a better chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the json decoder consumes the reader and there are cases where we
want to preserve the response body to further process outside sling a
flag to restore it has been included