Add response data streaming facility #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here we add a new ResponseDecoder: ByteStreamer. This allows user to get a stream of bytes 'as is' i.e. without any decoding. This is useful for all those streaming use cases like downloading files, binary blobs etc. This is also useful when response data is just plain text for e.g. the 5XX responses from API gateways. Side changes: - The xml stuff in testing code no longer needed as this new decoder is used as non-default decoder. - Code reformatting as per gopls/gofumpt style.
|
Closing as changes are now part of newly maintained hard fork https://github.com/rsjethani/rsling |
1 similar comment
|
Closing as changes are now part of newly maintained hard fork https://github.com/rsjethani/rsling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add a new ResponseDecoder: ByteStreamer. This allows user to get a stream of bytes 'as is' i.e. without any decoding. This is useful for all those streaming use cases like downloading files, binary blobs etc.
This is also useful when response data is just plain text for e.g. the 5XX responses from API gateways.
Side changes:
The xml stuff in testing code no longer needed as this new decoder is used as non-default decoder.
Code reformatting as per gopls/gofumpt style.