Implementing PartialEq; adding assert_r_eq! macro #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkf
commented
Aug 27, 2023
Comment on lines
+109
to
114
| fn numeric_input() { | ||
| assert_r_eq!( | ||
| R{ paste(1, 2, collapse = NULL) }, | ||
| R{ "1 2" } | ||
| ); | ||
| } |
There was a problem hiding this comment.
@armenic Added some test helpers! Much less boilerplate needed now to test the R interface. Hopefully this makes it easier to keep up with test writing. Thanks for being the driving force behind getting us started with more testing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartialEqfor all lang and ast objectsPartialEqforPrimitives, thankfully covered in "Learning Rust" and was pretty easy to adapt.assert_r_eq!macro that will parse and evaluate (most) R code and compare the output of the test case and expectation