Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generically forward keyword arguments #73

Merged
merged 1 commit into from
May 13, 2023
Merged

Generically forward keyword arguments #73

merged 1 commit into from
May 13, 2023

Conversation

dgollahon
Copy link
Owner

@dgollahon
Generically forward keyword arguments
6229e93 
- This should always be safe to do and may be required depending on the method we are hijacking. I did not do this previously due to differences in 2.7 and later versions of ruby but now that [ruby 2.7 is no longer supported](#72) it makes sense to do this everywhere.
- Related to #71
- Closes #46
@dgollahon dgollahon merged commit 8357d04 into master May 13, 2023
@dgollahon dgollahon deleted the generically-forward-kwargs branch May 13, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ruby 3.x compatibility
1 participant
@dgollahon