fix(Txn): serializable behavior is broken #2057 #2058
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This PR is a try to fix #2057.
For the details, please see #2057 (comment)
This PR changes
conflictKeys
field fromconflictKeys map[uint64]struct{}
toconflictKeys map[uint64]int
. The int is the length of thereads []uint64
; store it so that when checking indirect conflict, we know the new write for each key happens after how many reads. And finally, when check conflicts, introduce a new loop to check logical conflicts (indirect conflicts).After the changes, badger's transaction model can handle this kind of write skew https://wiki.postgresql.org/wiki/SSI#Intersecting_Data.