Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Parser): Add directive argument validator #16

Merged
merged 2 commits into from
Mar 19, 2021
Merged

fix(Parser): Add directive argument validator #16

merged 2 commits into from
Mar 19, 2021

Conversation

all-seeing-code
Copy link

@all-seeing-code all-seeing-code commented Mar 19, 2021 •
edited
Loading

Before this fix, the library didn't validate arguments to the directives. This fix adds the validation and appropriate error handling.

@all-seeing-code all-seeing-code merged commit 7914f56 into master Mar 19, 2021
@all-seeing-code all-seeing-code mentioned this pull request Mar 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimanyusinghgaur abhimanyusinghgaur abhimanyusinghgaur approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@all-seeing-code @abhimanyusinghgaur