Skip to content

Fix formatting issues #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 28, 2018
Merged

Fix formatting issues #37

merged 2 commits into from
Dec 28, 2018

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Dec 20, 2018 •
edited by manishrjain
Loading

  • Update maintainer fields to my name and email address.
  • Fix most issues reported by pylint (some of them are false positives
    so I am ignoring them.

No functional changes.

This change is Reviewable

@martinmr
Fix formatting issues.
2df03c5 
* Update maintainer fields to my name and email address.
* Fix most issues reported by pylint (some of them are false positives
  so I am ignoring them.

This change has no functional changes.
@martinmr
Fix typo
39df4cf
@martinmr martinmr requested a review from danielmai December 20, 2018 22:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 62

  • 69 of 72 (95.83%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 95.192%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pydgraph/client_stub.py 11 12 91.67%
pydgraph/txn.py 42 44 95.45%
Files with Coverage Reduction New Missed Lines %
pydgraph/txn.py 2 93.22%
Totals Coverage Status
Change from base Build 59: 0.1%
Covered Lines: 198
Relevant Lines: 208
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 62

  • 69 of 72 (95.83%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 95.192%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pydgraph/client_stub.py 11 12 91.67%
pydgraph/txn.py 42 44 95.45%
Files with Coverage Reduction New Missed Lines %
pydgraph/txn.py 2 93.22%
Totals Coverage Status
Change from base Build 59: 0.1%
Covered Lines: 198
Relevant Lines: 208
💛 - Coveralls

@martinmr martinmr requested a review from manishrjain December 28, 2018 00:06
manishrjain
manishrjain approved these changes Dec 28, 2018
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 14 of 14 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danielmai)

@martinmr martinmr merged commit 6058634 into master Dec 28, 2018
@martinmr martinmr deleted the martinmr/various-fixes branch December 28, 2018 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmai danielmai Awaiting requested review from danielmai

1 more reviewer

@manishrjain manishrjain manishrjain approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmr @coveralls @manishrjain