Skip to content

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Jan 3, 2019

This change is Reviewable

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai)


README.md, line 124 at r1 (raw file):

`client.query()` uses a read-only transaction to execute the query.

I don't think you need two blank lines here.

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: just remove that extra line.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai)

@coveralls
Copy link

coveralls commented Jan 3, 2019

Pull Request Test Coverage Report for Build 90

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 94.898%

Files with Coverage Reduction New Missed Lines %
pydgraph/util.py 1 90.91%
Totals Coverage Status
Change from base Build 86: 0.0%
Covered Lines: 186
Relevant Lines: 196

💛 - Coveralls

Copy link
Contributor Author

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @martinmr)


README.md, line 124 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

I don't think you need two blank lines here.

Done.

@danielmai danielmai merged commit 827655f into master Jan 3, 2019
@danielmai danielmai deleted the danielmai/readme_readonlytxns branch January 3, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants