-
Notifications
You must be signed in to change notification settings - Fork 91
Update CI to cover python 3.7 #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @utkonos)
.travis.yml, line 7 at r1 (raw file):
sudo: required dist: trusty matrix:
Why can't we just list 3.7 next to 3.6 and 2.7? Is it because of the ubuntu version?
Also, from the release notes it doesn't look like 3.7 is a big change from 3.6 so it's fine replacing 3.6 with 3.7.
@martinmr The version of ubuntu is needed for python 3.7 unless you want to install python altinstall for each CI build. I made a minimal change to preserve the python and ubuntu version that you already have for 3.6 and 2.7. It would be great if you just replaced 3.7 for 3.6. Give me a sec and I'll add to this PR with that change and make the ubuntu version uniform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @utkonos)
Looks good. Thanks for your contribution. I am merging it now. |
This change is