Skip to content

Conversation

utkonos
Copy link
Contributor

@utkonos utkonos commented Jan 16, 2019

This change is Reviewable

@coveralls
Copy link

Pull Request Test Coverage Report for Build 101

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.408%

Totals Coverage Status
Change from base Build 98: 0.5%
Covered Lines: 187
Relevant Lines: 196

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 101

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 95.408%

Totals Coverage Status
Change from base Build 98: 0.5%
Covered Lines: 187
Relevant Lines: 196

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 16, 2019

Pull Request Test Coverage Report for Build 105

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.898%

Totals Coverage Status
Change from base Build 98: 0.0%
Covered Lines: 186
Relevant Lines: 196

💛 - Coveralls

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @utkonos)


.travis.yml, line 7 at r1 (raw file):

sudo: required
dist: trusty
matrix:

Why can't we just list 3.7 next to 3.6 and 2.7? Is it because of the ubuntu version?

Also, from the release notes it doesn't look like 3.7 is a big change from 3.6 so it's fine replacing 3.6 with 3.7.

@utkonos
Copy link
Contributor Author

utkonos commented Jan 16, 2019

@martinmr The version of ubuntu is needed for python 3.7 unless you want to install python altinstall for each CI build. I made a minimal change to preserve the python and ubuntu version that you already have for 3.6 and 2.7. It would be great if you just replaced 3.7 for 3.6. Give me a sec and I'll add to this PR with that change and make the ubuntu version uniform.

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @utkonos)

@martinmr martinmr merged commit 0731973 into hypermodeinc:master Jan 17, 2019
@martinmr
Copy link
Contributor

Looks good. Thanks for your contribution. I am merging it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants