Skip to content

Change version to 1.0.2 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 19, 2019
Merged

Change version to 1.0.2 #52

merged 3 commits into from
Mar 19, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Mar 19, 2019 •
edited by manishrjain
Loading

This change is Reviewable

@martinmr martinmr requested a review from danielmai March 19, 2019 18:32
@coveralls
Copy link

Pull Request Test Coverage Report for Build 119

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.924%
Totals Coverage Status
Change from base Build 117: 0.0%
Covered Lines: 187
Relevant Lines: 197
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 19, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 121

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.924%
Totals Coverage Status
Change from base Build 117: 0.0%
Covered Lines: 187
Relevant Lines: 197
💛 - Coveralls

danielmai
danielmai approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

After merging to master tag this as v1.0.2 and add it to release page.

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @danielmai)

danielmai
danielmai approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@martinmr martinmr merged commit f60b194 into master Mar 19, 2019
@martinmr martinmr deleted the martinmr/new-version branch March 19, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@danielmai danielmai danielmai approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmr @coveralls @danielmai