Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ring Access Controller #1053

Closed
parchmaf opened this issue Sep 14, 2022 · 6 comments
Closed

Support for Ring Access Controller #1053

parchmaf opened this issue Sep 14, 2022 · 6 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request wontfix This will not be worked on

Comments

@parchmaf
Copy link

Feature Request

Description

Ring Access Controller is used for opening and closing gates and it is a supported device within the Ring app. It would be nice if it was supported by this plugin for Homebridge

Describe the solution you'd like

All that is needed for this is a toggle switch. Ring Access Controller does not know if a gate is open or closed but if activated it will open or close regardless of state. Considering that this is a Ring branded device and already included in the Ring app, I would think this would be a relatively easy add-on.

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?

Device data

If you are requesting a new device be added to homebridge-ring, please follow the instructions in https://github.com/dgreif/ring/wiki/Data-Discovery and include the output here

Ring Data.pdf

@parchmaf parchmaf added the enhancement New feature or request label Sep 14, 2022
@tsightler
Copy link
Collaborator

This is a duplicate of #384. Unfortunately these devices are not actually part of the standard Ring API but actually completely different and use the Amazon Key API so adding them is non-trivial.

@dgreif
Copy link
Owner

dgreif commented Sep 15, 2022

@tsightler is spot on, see #384 (comment) for a full description

@dgreif dgreif closed this as not planned Won't fix, can't repro, duplicate, stale Sep 15, 2022
@dgreif dgreif added duplicate This issue or pull request already exists wontfix This will not be worked on labels Sep 15, 2022
@parchmaf
Copy link
Author

parchmaf commented Sep 15, 2022 via email

@tsightler
Copy link
Collaborator

tsightler commented Sep 15, 2022

Do you know this as a fact or is this just your belief? Just because it's visible in the Ring app does not mean it doesn't use the Amazon Key API. As described in the referenced issue, even though it appears in the Ring app, the Ring app itself is simply talking directly to the Amazon Key API to control this device rather than using the Ring API.

You can see this even in the device discovery data included when opening this issue. If you look through that data you will see that there are no locks other than the Z-wave locks, however, there is this entry at the end:

"amazonKeyLocks":[{"locks":["d4c01621-fab8-4b6d-9e8f-1b29224d1491"],"migrated":[true]}]}

That still looks like an Amazon Key lock to me, and it still has all of the Amazon Key features, so I'm guessing it's still controlled by the Amazon Key API. However, if you have information that shows that this lock can now be controlled via the Ring API, feel free to post the API endpoints, there's certainly nothing in the device discovery that would indicate any change.

@parchmaf
Copy link
Author

parchmaf commented Sep 15, 2022 via email

@tsightler
Copy link
Collaborator

I think you may be confusing the Amazon Key app with the Amazon Key API/service. Just because they've removed the lock from the app does not mean it no longer uses the Amazon Key API/service to control it. Amazon Key is mostly intended to be a service provided by Amazon to be consumed by other access control vendors and, as far as I can tell, Ring is simply doing this directly from their app, as they always have, previously the lock was simply also available in the Amazon Key app.

Admittedly I could be wrong, but nothing in the data dump appears to indicate any change in regard to the APIs used to control the lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants