VS2017 15.9.12 Fixes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the RustLanguageExtension.dll assembly is loaded fine for intellisense, syntax highlighting, etc. - the Tools > Options > Rust page fails to load the appropriate assembly. This might be related to VS2017 breaking changes[1], but I'm not 100% sure what's going on. I'm not even sure this isn't a bug in VS, given that only the options page is unable to load the assembly, but at least we have a fix [2]. [1] https://docs.microsoft.com/en-us/visualstudio/extensibility/breaking-changes-2017?view=vs-2019#change-global-assembly-cache-gac [2] https://social.msdn.microsoft.com/Forums/en-US/39ca5319-96af-4de7-b2d1-4d28154321b4/vsix-options-dialog-does-not-always-load-in-vsix-extension?forum=vsx#b209ab3b-6f0d-493f-a322-c25e4ed6b82e
RustLanguageExtension.csproj already specifies these settings, but this version of VS2017 appears to ignore those completely. Adding a new launchSettings.json appears to fix the problem.
|
Is the options dialog issue consistent for you? I've never seen this problem before. |
|
Yes, it's 100% consistent for me when building from
And the options don't show, being replaced by "An error occurred loading this property page". The relevant record from <entry>
<record>2005</record>
<time>2019/05/31 20:30:20.475</time>
<type>Error</type>
<source>VisualStudio</source>
<description>CreateInstance failed for package [RustLanguageExtensionOptionsPackage]Source: 'mscorlib' Description: Could not load file or assembly 'RustLanguageExtension, Version=0.5.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
System.IO.FileNotFoundException: Could not load file or assembly 'RustLanguageExtension, Version=0.5.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
File name: 'RustLanguageExtension, Version=0.5.0.0, Culture=neutral, PublicKeyToken=null'
 at System.Reflection.RuntimeAssembly._nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
 at System.Reflection.RuntimeAssembly.nLoad(AssemblyName fileName, String codeBase, Evidence assemblySecurity, RuntimeAssembly locationHint, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
 at System.Reflection.RuntimeAssembly.InternalLoadAssemblyName(AssemblyName assemblyRef, Evidence assemblySecurity, RuntimeAssembly reqAssembly, StackCrawlMark& stackMark, IntPtr pPrivHostBinder, Boolean throwOnFileNotFound, Boolean forIntrospection, Boolean suppressSecurityChecks)
 at System.Activator.CreateInstance(String assemblyString, String typeName, Boolean ignoreCase, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes, Evidence securityInfo, StackCrawlMark& stackMark)
 at System.Activator.CreateInstance(String assemblyName, String typeName)
 at System.AppDomain.CreateInstance(String assemblyName, String typeName)

WRN: Assembly binding logging is turned OFF.
To enable assembly bind failure logging, set the registry value [HKLM\Software\Microsoft\Fusion!EnableLog] (DWORD) to 1.
Note: There is some performance penalty associated with assembly bind failure logging.
To turn this feature off, remove the registry value [HKLM\Software\Microsoft\Fusion!EnableLog].
</description>
<guid>{B57536CB-0310-4E50-907B-A14610127C49}</guid>
<hr>80004005 - E_FAIL</hr>
<errorinfo></errorinfo>
</entry>Using |
|
Oh, I see what's going on. This doesn't happen from the marketplace builds since they are from before I switched to a CPS project. The new one isn't generating a codebase entry in the |
ZoeyR
reviewed
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of minor fixes for the following issues: