Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PMD v7.x.x #168

Open
emouty opened this issue Jan 10, 2024 · 1 comment
Open

Support PMD v7.x.x #168

emouty opened this issue Jan 10, 2024 · 1 comment
Assignees
@dykov
Labels
enhancement New feature or request
Milestone
0.3.0

Comments

@emouty
Copy link
Contributor

emouty commented Jan 10, 2024

Summary

With version 7, pmd will introduce a lot of changes in its apis. So it could be a good idea to work on migrating arch4u rules to these new apis.

The migration guide can be found here : https://pmd.github.io/pmd/pmd_userdocs_migrating_to_pmd7.html
@dgroup dgroup assigned dykov and unassigned dgroup Jan 19, 2024
dgroup added a commit that referenced this issue Sep 23, 2024
@dykov @dgroup
#168: Upgrade to pmd7 (#178)
9bc03f4 
* AvoidProhibitedMethodsUsage - Fix deprecated warnings

* MissingMandatoryAnnotation - Fix deprecated warnings

* ObfuscationRequired - Fix deprecated warnings

* PotentiallyThreadLocalPollutionByMdc - Fix deprecated warnings

* UseExistingConstant - Fix deprecated warnings

* WrongRestMethodSignature - Fix deprecated warnings

* Checkstyle fixes

* Optimize imports

* Ignore rule tests

* Upgrade PMD dependency version to 7.4.0

* Fix AvoidProhibitedMethodsUsage rule

* Fix AvoidProhibitedClasses rule - from XPath to Java

* Fix ObfuscationRequired rule

* Fix AvoidMdcOutsideTryStatement rule - from XPath to Java

* Fix PotentiallyThreadLocalPollutionByMdc rule

* Fix AvoidUsingObjectMapperAsALocalVariable rule - from XPath to Java

* Update Copyright

* Update RestEndpointsWithoutExposedMetrics rule

* Fix UseConstantAsMetricName rule - from XPath to Java

* Reformat code

---------

Co-authored-by: Yurii Dubinka <yurii.dubinka@gmail.com>
@dgroup dgroup added enhancement New feature or request and removed new rule labels Sep 29, 2024
@dgroup
Copy link
Owner

dgroup commented Sep 29, 2024 •
edited by unfurl-links bot
Loading

Work started in https://github.com/dgroup/arch4u-pmd/tree/168-wip-pmd-7.x

GitHub
Linting rules for Java frameworks like Spring, Quarkus, Jackson, SLF4J, etc., to avoid known problems in REST API, logging, observability, performance, and general best practices. - GitHub - dgroup...

@dgroup dgroup added this to the 0.3.0 milestone Oct 14, 2024
@dgroup dgroup mentioned this issue Oct 14, 2024
Merged
@dgroup dgroup changed the title Migrate codebase to pmd 7 Support PMD v7.x.x Oct 15, 2024
dgroup added a commit that referenced this issue Oct 31, 2024
@dgroup @dykov
#168 wip pmd 7.x (#184)
6a3acb7 
* #168: Upgrade to pmd7 (#178)

* AvoidProhibitedMethodsUsage - Fix deprecated warnings

* MissingMandatoryAnnotation - Fix deprecated warnings

* ObfuscationRequired - Fix deprecated warnings

* PotentiallyThreadLocalPollutionByMdc - Fix deprecated warnings

* UseExistingConstant - Fix deprecated warnings

* WrongRestMethodSignature - Fix deprecated warnings

* Checkstyle fixes

* Optimize imports

* Ignore rule tests

* Upgrade PMD dependency version to 7.4.0

* Fix AvoidProhibitedMethodsUsage rule

* Fix AvoidProhibitedClasses rule - from XPath to Java

* Fix ObfuscationRequired rule

* Fix AvoidMdcOutsideTryStatement rule - from XPath to Java

* Fix PotentiallyThreadLocalPollutionByMdc rule

* Fix AvoidUsingObjectMapperAsALocalVariable rule - from XPath to Java

* Update Copyright

* Update RestEndpointsWithoutExposedMetrics rule

* Fix UseConstantAsMetricName rule - from XPath to Java

* Reformat code

---------

Co-authored-by: Yurii Dubinka <yurii.dubinka@gmail.com>

* Apply generic formatting

* qulice fixes

* Ignore qulice checkstyle & pmd for now

* Enable jacoco and tests execution

* Fixed pmd issues

* Fixed few checkstyle issues

* fix UseOpenApiInRestEndpoints, NoMandatoryConstructorInExceptionClass (xpath), UseExistingConstant

* fix ruleset rules

* fix checkstyle in UseExistingConstant

* enable tests

* remove checkstyle exclude in qulice

* fix qulice PotentiallyThreadLocalPollutionByMdc

* fix qulice WrongRestMethodSignature

* fix qulice AvoidTypeAsLocalVariable

* fix qulice UseConstantAsMetricName

* fix qulice AvoidProhibitedMethodsUsage

* fix qulice AvoidMdcOutsideTryStatement

* fix qulice AvoidProhibitedClasses

* fix qulice UseExistingConstant

* fix qulice ObfuscationRequired

* Fixed few checkstyle issues

* Increase code quality thresholds

* change pmd version in readme

* Upgrade JDK8 in CI

* Upgrade JDK8 in CI

* Upgrade JDK8 in CI

* mvn verbose

* upgrade mvn surefire, failsafe plugins

* Use JDK11 for CI

* Sonarqube fixes

---------

Co-authored-by: Oleksii Dykov <dykovoleksii@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dykov dykov

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@dgroup @emouty @dykov