Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @include_once to load plugins composers dependencies. #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ovenum
Copy link

@ovenum ovenum commented May 3, 2023

Closes #2

When installing Kirby with composer getkirby/composer-installer takes care of installing the plugins composer dependencies into the main composer vendor directory.

You can the check the the Kirby Plugin guide for further information on how to setup the plugin to support different installation methods.

Note that you should not require the autoloader, as it will only be present if the plugin is installed manually or via a Git submodule. Our custom Composer installer will delete the vendor directories from plugins to avoid code duplication and autoloading issues. By using @include_once, you tell PHP to load the file only if it exists.

@tobimori
Copy link

tobimori commented Jun 3, 2023

hey @Foddy, would be great to get this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Composer installation broken
2 participants