-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out None points when calculating RTT #15
base: master
Are you sure you want to change the base?
Conversation
Fix dgzlopes#14 Signed-off-by: Rascal_Two <therealrascaltwo@gmail.com>
2334b6e
to
281b645
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @RascalTwo. Thanks a lot for the fix! LGTM.
I prefer the list comprehension, is more Pythonic 💯
On the other hand, can you add the changes for solving last latency_point not being included in RTT calculations
issue?. If not, I can create one PR with the fix.
Thanks, glad you like it - I also prefer the list comprehension too. Would you prefer the |
Signed-off-by: Rascal_Two <therealrascaltwo@gmail.com>
Feel free to add a second commit. I can |
All done - thanks for sharing this project and taking the time to review! |
Is this branch going to be merged with master? |
Would the |
Fix #14
Filter's out the
None
points fromlatency_points
to prevent themin
,mean
, andmax
from receiving anyNone
values and throwing an error.If preferred, I could use
filter()
over the list comprehension I used: