Cache imports that contain imports. #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant to dhall-lang#362. Previously, if an import contained additional imports, it wouldn’t get cached. This fixes that, with a couple related changes: - type checking happens in the failed-lookup branch, rather than having to return a `cached` boolean, - the normalized form of the import is used more consistently (although this doesn’t fix the related normalization problem around `../`)
|
BTW, my branch is a few commits behind master, because I didn’t want to modify all my configs with the Integer/Natural change just to experiment with this. |
|
Looks great to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to #362.
Previously, if an import contained additional imports, it wouldn’t get
cached. This fixes that, with a couple related changes:
return a
cachedboolean,doesn’t fix the related normalization problem around
../).